GithubHelp home page GithubHelp logo

Comments (9)

arkivanov avatar arkivanov commented on June 13, 2024

Thanks for reporting the issue. How do you specify the animation exactly? Can show some code? In the sample you are using noAnimation.

from decompose.

mvarnagiris avatar mvarnagiris commented on June 13, 2024

Yeah I specifically set it to noAnimation. The bug is reproducible with this. Seems like as long as StackAnimator is set, the bug can be reproduced - the animation itself does not matter.

from decompose.

mvarnagiris avatar mvarnagiris commented on June 13, 2024

To reproduce the bug you might need to tap restart about like 5-10 times. If it does not happen then maybe tweak the first value by increasing it a bit

from decompose.

arkivanov avatar arkivanov commented on June 13, 2024

Thanks! Is it also reproducible if you specify the animation as follows?

selector = { noAnimation() },

Instead of

selector = { _, _, _ -> noAnimation() },

from decompose.

mvarnagiris avatar mvarnagiris commented on June 13, 2024

Oh interesting. If I do

            animation = stackAnimation(
                disableInputDuringAnimation = true,
                animator = noAnimation(),
            ),

Then I cannot reproduce

from decompose.

arkivanov avatar arkivanov commented on June 13, 2024

Thanks for confirming! There are three overloads of the stackAnimation animation function. The one with selector = { child, otherChild, direction -> ... } is annotated with @FaultyDecomposeApi for a reason. Please see the docs for that overload.

I think it's yet another bug in Compose movableContent function. There were few other bugs with movableContent in the past, but they all were fixed. Could you please also try updating or downgrading the version of Compose and see if it changes anything? If it's not yet fixed in a newer Compose version, then we should create a reproducer with movableContentOf but without Decompose (should be pretty easy to do), and report it here. I might help with the reproducer, let me know.

from decompose.

mvarnagiris avatar mvarnagiris commented on June 13, 2024

Ah ok cool I might be able to update our code to not use that MovableStackAnimation. Although we do rely on Direction. I will try to create a reproduced without decompose. Will ping you if I need help with that. Thanks a lot!

from decompose.

arkivanov avatar arkivanov commented on June 13, 2024

Thank you!

from decompose.

arkivanov avatar arkivanov commented on June 13, 2024

I have extracted a reproducer without Decompose and filed b/327814644. Closing this issue for now. Thanks again!

from decompose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.