v4.1.1 fails to build on on Debian buster i386 about bluez-alsa

[borine]

Yes, BlueALSA v4.1.1 requires libglib2.0 version 2.64 or later in order to generate the D-Bus interface code. This should be documented, I will update the wiki page.

See the option --glib-min-required= in the gdbus-codegen manual page (of version 2.64 or later!) for more detail on what is wrong (Bluez and BlueALSA both use file descriptor parameters)

[D1eter]

Okay, thanks. v4.1.0 will do just fine.

[D1eter]

Closing as there is actually no issue.

[borine]

On further investigation, it turns out this is an old bug in gdbus-codegen; The fix appeared in glib2.0 release 2.61.0 - see
GNOME/glib@5649255

@arkq - One possible workaround for BueALSA to work with older glib2.0 versions would be to move the BatteryProvider1 interface declaration lower down in the bluez-iface.xml file, so that the first interface is MediaEndpoint1 which does have methods and therefore this bug would not be triggered. The same applies to the Manager1 interface in bluealsa-iface.xml

@D1eter - could you possibly try that workaround with BlueALSA 4.1.1 on your buster installation to check that it really does fix this issue?

[D1eter]

Sure, just tell me what to do. Note that Debian buster has glib2.0 release 2.58.3. Will that do?

[borine]

glib2.0 release 2.58.3. Will that do?
Yes, any release before 2.61 has the bug linked above.

To test this workaround, apply this patch before running configure:

diff --git a/src/bluealsa-iface.xml b/src/bluealsa-iface.xml
index ef14291..d81f173 100644
--- a/src/bluealsa-iface.xml
+++ b/src/bluealsa-iface.xml
@@ -7,13 +7,6 @@
 -->
 <node>
 
-	<interface name="org.bluealsa.Manager1">
-		<property name="Version" type="s" access="read"/>
-		<property name="Adapters" type="as" access="read"/>
-		<property name="Profiles" type="as" access="read"/>
-		<property name="Codecs" type="as" access="read"/>
-	</interface>
-
 	<interface name="org.bluealsa.PCM1">
 		<method name="Open">
 			<arg direction="out" type="h" name="fd_pcm"/>
@@ -41,6 +34,13 @@
 		<property name="Volume" type="q" access="readwrite"/>
 	</interface>
 
+	<interface name="org.bluealsa.Manager1">
+		<property name="Version" type="s" access="read"/>
+		<property name="Adapters" type="as" access="read"/>
+		<property name="Profiles" type="as" access="read"/>
+		<property name="Codecs" type="as" access="read"/>
+	</interface>
+
 	<interface name="org.bluealsa.RFCOMM1">
 		<method name="Open">
 			<arg direction="out" type="h" name="fd"/>
diff --git a/src/bluez-iface.xml b/src/bluez-iface.xml
index 83568ce..7f46eba 100644
--- a/src/bluez-iface.xml
+++ b/src/bluez-iface.xml
@@ -7,12 +7,6 @@
 -->
 <node>
 
-	<interface name="org.bluez.BatteryProvider1">
-		<property name="Device" type="o" access="read"/>
-		<property name="Percentage" type="y" access="read"/>
-		<property name="Source" type="s" access="read"/>
-	</interface>
-
 	<interface name="org.bluez.MediaEndpoint1">
 		<method name="SelectConfiguration">
 			<arg direction="in" type="ay" name="capabilities"/>
@@ -29,6 +23,12 @@
 		</method>
 	</interface>
 
+	<interface name="org.bluez.BatteryProvider1">
+		<property name="Device" type="o" access="read"/>
+		<property name="Percentage" type="y" access="read"/>
+		<property name="Source" type="s" access="read"/>
+	</interface>
+
 	<interface name="org.bluez.Profile1">
 		<method name="NewConnection">
 			<arg direction="in" type="o" name="device"/>

If you are not sure how to apply a patch, then instead you can edit the files src/bluealsa-iface.xml and src/bluez-iface.xml instead. In each file just move the first

<interface name=...>
...
</interface>

block so that it becomes the second interface block.

[D1eter]

With the patch v4.1.1 builds without problems. Listening to v4.1.1 just now. Thanks!

[arkq]

@borine many thanks for finding a cause of that, and many thanks to @D1eter for testing.
Regarding the glib version, it seems that anyway I will have to bump minimal requirement to at least 2.57.2 2.58.2, because it's the first version when gdbus-codegen has got --interface-info-body option... I will check whether everything builds correctly with that version.

EDIT: In 2.57.2 there are other issues with gdbus-codegen, it seems that minimal version is actually 2.58.2