GithubHelp home page GithubHelp logo

Comments (7)

shabbirbharmal avatar shabbirbharmal commented on July 28, 2024

That's right, it is just default behavior.

from nova-tab.

XGhozt avatar XGhozt commented on July 28, 2024

@shabbirbharmal -- Yes, but it should be disabled. Why did you close this?

https://vuejs.org/v2/guide/events.html

event.stopPropagation()

from nova-tab.

shabbirbharmal avatar shabbirbharmal commented on July 28, 2024

Because that is the default behavior of tab component I am using and I didn't see any option to change it or make it configurable. Let me know if you think we are not on the same page with the issue you are facing.

from nova-tab.

XGhozt avatar XGhozt commented on July 28, 2024

It doesn't need to be a configurable option. The page simply shouldn't move at all when you change tabs. Just like most other websites. A good example is github right here when you add a reply, there is a "Write" and "Preview" tab on the editor. The page doesn't scroll.

If the page moves when users are clicking a tab, it's very disorienting and the first thing they will do is scroll back up. I'm not familiar enough with Vue or Nova to get this installed. Bust in native javascript or any other library it's usually a one liner added to the click event to disable the browsers default behavior.

from nova-tab.

XGhozt avatar XGhozt commented on July 28, 2024

Is this what you're using?

https://github.com/spatie/vue-tabs-component

It doesn't happen in the demo on that website.
Can you confirm it's happening in your Laravel Nova installation, too?

Demo: http://vue-tabs-component.spatie.be/

  • Make your window smaller to confirm no scrolling happens.

from nova-tab.

shabbirbharmal avatar shabbirbharmal commented on July 28, 2024

I see what is happening here. URL fragment is conflicting with Nova's Vue router. Will have to disable URL fragment to fix this

from nova-tab.

XGhozt avatar XGhozt commented on July 28, 2024

Awesome, hopefully it's not to difficult.

from nova-tab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.