Comments (1)
Just to note why this is the more pragmatic solution...
The issue here is libraries that cache references to DOM globals. e.g. something that looks like this:
var w = window;
w.$ = w.Zepto = function(){}
Then let's say we have a view:
var $ = require('zepto');
var MyView = function() {
$('.el').html('foo')
}
This means through the lifecycle of the process w
in Zepto will refer to a local copy of that instance of window
. This is problematic when using benv.teardown(true)
b/c it will delete the global instances of window
and the next benv.setup
will create a new window
+ DOM environment. Meanwhile our view is still holding on to a cached require('zepto')
which is holding on to that old instance of window
in w
.
There are two options to solve this problem 1. Be diligent in setting up and tearing down a clean DOM by clearing out require caches until the code is always re-setting var w = window
2. Let benv hold on to one instance of the DOM per process and let the programmer deal with setup/teardown of mutating global DOM state. We are choosing the latter because the former has proven even more tedious of a black box to understand (e.g. when to require/rewire/clear cached modules/etc.) whereas the latter is more obvious and closer to what one would be dealing with in typical browser testing.
from benv.
Related Issues (14)
- Libraries will cache references to window or document
- jQuery still holds the previous window object HOT 2
- Consider "global locals" helper
- requireWithJadeify might not need to specify variables HOT 1
- benv.expose should also attach to the window object
- Cannot install benv on node 4.2 (jsdom update required) HOT 1
- Node not defined HOT 1
- Bubble up jade errors better
- Need to set URL as JSdom started to check CORS HOT 1
- benv.expose Should add to window as well
- Add promise API HOT 1
- jsdom v10 api change breaks benv HOT 1
- Jsdom 12 has removed old-api.js HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from benv.