GithubHelp home page GithubHelp logo

Comments (9)

Mrpanquecas avatar Mrpanquecas commented on May 4, 2024 1

I can try and make a PR for that,

would you prefer a simple check like this:

props => props.width ? ${props.width}px : '100%'

or a little more complex check that allows the user to choose the type of width measurement?
IMO the user should always specify the type and resort to px if none is chosen

from react95.

Mrpanquecas avatar Mrpanquecas commented on May 4, 2024 1

Yes i will try to solve this issues ASAP, keep up the really good work

from react95.

Mrpanquecas avatar Mrpanquecas commented on May 4, 2024 1

Awesome! I will try it out right now in my project! thanks a lot for the explanation!

from react95.

arturbien avatar arturbien commented on May 4, 2024

@Mrpanquecas I think we could approach it in exact same way as in <TextField /> component. Same thing should also be done in <Select /> component. #46. Do you want to solve these issues? 😊 thanks a lot for getting involved!

from react95.

Mrpanquecas avatar Mrpanquecas commented on May 4, 2024

I've modified the select to be able to get 100% of the width.
the progressbar is a bit more tricky because when you put 100% width in the BlueBar component it gets 100% of the parent so the display of the progress percentage is never placed right. Any ideas to fix this?

also i'm not able to commit (it's my first time contributing ever) how is that process done? (can't push to new/old branches)

from react95.

arturbien avatar arturbien commented on May 4, 2024

@Mrpanquecas ok so for now just make a pull request for the Select component changes (#46). You can see a nice tutorial on how to do it here. As for the Progress component- I can take care of that and I will let you know how I solved the issue, ok? 😊

from react95.

arturbien avatar arturbien commented on May 4, 2024

@Mrpanquecas you can check my solution for the Progress component now 😊 basically I used css property clip-path so the blue bar is always of 100% width but then I only crop out percentage % of its width, so the rest becomes invisible

from react95.

arturbien avatar arturbien commented on May 4, 2024

🎉 This issue has been resolved in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

from react95.

arturbien avatar arturbien commented on May 4, 2024

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from react95.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.