Suggestion about Morph.json about changeling

[James103]

Do you have the exact morphs.json available to upload here?

See mchorse#243

[Keebsz]

morph.zip
I had to make it a zip file since I wasn't allowed to send the .json

[asanetargoss]

Thanks for opening an issue for this.

First and foremost, Changeling is licensed under the MIT license, which is very flexible in what you are allowed to do. If you were redistributing the mod itself or the source code, I would recommend learning more about the license. But since you're not doing either of those things, you're pretty much free to do whatever you want, including uploading your configuration to Curseforge, no permission required.

I will look at the morphs JSON later and decide whether it's a good fit for the mod or not.

[asanetargoss]

The JSON looks fine. Would you be alright with formatting it (Such as with: https://jsonformatter.curiousconcept.com/ ), adding it to the existing morphs.json, and opening a pull request?

[Keebsz]

Sure. In the time doing this I also made changeling compatible for The Twilight Forest. May I also add that in?
Another thing, I just want to let you know that some mobs glitch the game out.
With the Ice and Fire mod, the mob id for glitched out mobs are:
iceandfire:seaserpent

For the Aether mod:
aether_legacy:swet

[asanetargoss]

Feel free to add or change anything. I will be able to review it in the pull request.

How are these mobs "glitching out" exactly?

[asanetargoss]

I just did a large pull from upstream which made changes to vanilla mob configs.

I see this issue has not had activity. These configs likely won't work on 1.10, due to the mob ID overhaul between 1.10 and 1.11. For that reason, I recommend a pull request against changeling-1.11

If it is better, I or someone else could add @Kevini-i 's configs, however they would have to give permission first.

[Keebsz]

@asanetargoss you have my permission to do whatever you like to the config. The only thing I didn't do was specify what type of morph was a mob. For the Aether, I believe one of the bosses wasn't created since I never got around to it. There were a few mobs I did blacklist because it caused a glitch

The blacklist:
"iceandfire:seaserpent",
"aether_legacy:swet",
"betternether:firefly",
"iceandfire:firedragon"
"iceandfire:icedragon"

Everything pretty much crashed you besides the iceandfire dragons. they were just buggy in terms in didn't move right when you were to fly.

I am going to open a pull request now. Sorry for the long wait.

[kernbruv]

so just replace the morphs.json and its good to go?

[asanetargoss]

so just replace the morphs.json and its good to go?

What are you trying to do?