link:<url>[Link text] not highlighted properly in editor about asciidoctor-vscode

[ggrossetie]

My guess is that the syntax highlighter does its job correctly but the built-in theme has no color (or a very light color) associated with the "token".

Here's the rule we are using:

asciidoctor-vscode/syntaxes/Asciidoctor.json

Lines 965 to 983 in e190123

	"name": "markup.other.url.asciidoc",
	"match": "(?<!\\\\)(link|mailto):([^\\s\\[]+)(?:\\[((?:\\\\\\]|[^\\]])*?)\\])",
	"captures": {
	"1": {
	"name": "entity.name.function.asciidoc"
	},
	"2": {
	"name": "markup.link.asciidoc",
	"patterns": [
	{
	"include": "#attribute-reference"
	}
	]
	},
	"3": {
	"name": "string.unquoted.asciidoc"
	}
	}
	},

link is identified as entity.name.function.asciidoc and indeed this token is only defined in "dark_plus" included in "dark_modern":

https://github.com/microsoft/vscode/blob/58041888f48dc35ab6f4885765b7a45d1d67fe8e/extensions/theme-defaults/themes/dark_plus.json#L6-L18

You might want to open a new feature request at https://github.com/microsoft/vscode/issues.

[Oobiewan]

I just switched to the "Dark Modern" theme (from the default VS Code dark), and "link:" is now highlighted as expected. I'm not sure if this means that the issue can be closed.