Impossible to set custom route in shortURL make about short-url

[ash-jc-allen]

Hi @paoloveggi,

Sorry to hear that you're having issues.

If I understand your problem right, it seems like everything is working as intended.

If we look at this example and assume that our app's URL is https://webapp.com:

$shortUrl = $builder->destinationUrl('https://destination.com')->urlKey('custom-key')->make();

By using the above code, you'd create a new ShortURL in the database that had the default_short_url as https://webapp.com/short/custom-key. The default short URL is only intended as the default URL if you are using the controller and route together that come with the package.

If you then wanted to use your route structure, you should be able to go to this URL:

 https://webapp.com/s/custom-key

I've just tested this locally and it seems to work as expected. Please let me know if you're still having issues and try to provide some screenshots, code examples or stack traces so I can try and help out a bit more 😄

[paoloveggi]

Hello,

ok I understood. In my opinion it would be better if in database you store the real shortURL generated by the make() function, anyway it works and I checked the visited links table and it's ok as well.

Nice work,
thank you.

[moljac024]

This sounds broken to me. What good is the default_short_url column? How about we make it instead a short_url column and ask users for a callback function that will generate it given a custom-key ?

The callback could be optional and the default one would just generate urls the way it currently does.

[ash-jc-allen]

@moljac024 This is 100% the intended behaviour and is working as expected. When you generate the short URL, it will populate the default_short_url so that you can quickly grab the link for the model if you're using the default route and controller provided by the package.

If you're not using the default route and controller, there isn't currently a way to store any custom URLs on the model. If you have any ideas about how you might be able to improve or add to the library, I'd be happy to look at any pull requests.