GithubHelp home page GithubHelp logo

Comments (8)

Tratcher avatar Tratcher commented on June 27, 2024

Side note: Your implementation won't work in many scenarios.
https://github.com/sblackler/Owin.Hsts/blob/master/Owin.Hsts/HstsMiddleware.cs#L27

The response headers can be sent during the call to Next, so changes done after Next may fail. You should move all that logic to the OnSendingHeaders event. See http://owin.org/spec/CommonKeys.html

from security.

 avatar commented on June 27, 2024

Ah, I didn't realise that was there. I'll fix that this evening when I get a chance.

from security.

 avatar commented on June 27, 2024

Updated to use OnSendingHeaders (commit: https://github.com/sblackler/Owin.Hsts/commit/f69e78df94ccfabc1fd8000717717cf42d9201b7)

from security.

Eilon avatar Eilon commented on June 27, 2024

@blowdart

from security.

blowdart avatar blowdart commented on June 27, 2024

Given multiple implementations, including nwebsec from @klings I don't feel providing a more limited middleware is that useful.

from security.

 avatar commented on June 27, 2024

@blowdart thanks for the info about nwebsec. Didn't realise that existed (don't know if it did a year a go when I started this). I think it would be good to raise awareness for stuff like this, maybe through a blog post or something? :)

from security.

blowdart avatar blowdart commented on June 27, 2024

That would be a good idea. I'll find someone that blogs and poke them with a stick.

from security.

StefanOssendorf avatar StefanOssendorf commented on June 27, 2024

Or https://github.com/StefanOssendorf/SecurityHeadersMiddleware/ ;-)

from security.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.