GithubHelp home page GithubHelp logo

Comments (5)

Eilon avatar Eilon commented on August 30, 2024

We can certainly do this, but what would actually wire it up in our tests? And... what problem in our tests does it solve?

from testing.

analogrelay avatar analogrelay commented on August 30, 2024
  1. The new test host in dotnet test suppresses Console output. So if we want to write something out, we need to use this.

  2. The ITestOutputHelper collects output for a single test and ensures it is rendered as a discrete unit, which is important when doing parallel testing

  3. Tests would have to wire it up themselves. This is for tests that currently create a Logger Factory and attach the Console logger. Mostly functional tests that do deployment.

from testing.

Eilon avatar Eilon commented on August 30, 2024

Ah, got it, this makes sense. Are there any tests where we know we'd want to use this ASAP? I want to make sure that whoever I assign this to will have an actual use case for it 😄

from testing.

analogrelay avatar analogrelay commented on August 30, 2024

Well there are places we already have it, https://github.com/aspnet/SignalR/blob/dev/test/Microsoft.AspNetCore.SignalR.Tests/XUnitLoggerProvider.cs , https://github.com/aspnet/MusicStore/blob/dev/test/E2ETests/Common/XunitLogger.cs , etc.

So this more about making it a common component, to avoid copy 🍝

from testing.

analogrelay avatar analogrelay commented on August 30, 2024

Closing in lieu of aspnet/Logging#574

from testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.