originalSchema for CommonModel should be called originalInput about modelina

[magicmatatjahu]

@jonaslagoni Maybe we should have originalInput next to originalSchema? I mean, if we will have processor for graphql data from SDL to JSON Schema, then finally we must process JSON Schema not SDL, so originalSchema should stay.

[jonaslagoni]

Agreed in many cases if ever passed through the JSON Schema input processor it would stay originalSchema.

However, if you provide another processor which does something completely different XML for example, it does not have to convert the XML into JSON for the JSON Schema input processor but can create the CommonModel representation itself.

Then originalSchema would not make sense since it would now be originalStructor or what ever you could call it. Therefore a more neutral name such as originalInput makes more sense IMO.

[magicmatatjahu]

This is a one of POV, but here is also a question: why we want to processor xml in custom way, if we have possibility to change xml to json and then process it as JSON Schema? :) OriginalSchema/OriginalInput should be also useful to read it from code, using pure GraphQL or XML you haven't this option.

[jonaslagoni]

@magicmatatjahu XML is just an example, could by any type of input, with its own InputProcessor that does not use the JSON Schema simplifier. They could handle their own processing of transforming the input to CommonModels. Which means that OriginalSchema makes no sense.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

[asyncapi-bot]

🎉 This issue has been resolved in version 0.31.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀