GithubHelp home page GithubHelp logo

Comments (2)

linsolas avatar linsolas commented on September 22, 2024

Hello,

Not perfectly sure my problem is related to this incompatibility, but with 2.4.7 the loader does not get the query options, while with 2.4.5 everything is OK. In the loaderUtils.getOptions, it expect an object with the query parameter (code here) :

function getOptions(loaderContext) {
	const query = loaderContext.query;
	if(typeof query === "string" && query !== "") {
		return parseQuery(loaderContext.query);
	}
	if(!query || typeof query !== "object") {
		// Not object-like queries are not supported.
		return null;
	}
	return query;
}

However, the nunjucks-loader is giving a string:

   if (!hasRun){
        var query = loaderUtils.getOptions(this.query);

and thus, the query object is null everytime. If I change the previous line to:

   if (!hasRun){
        var query = loaderUtils.getOptions({query: this.query});

then it works as expected.

note: I'm using Webpack 1 in my project and my Webpack configuration is like that:

{
  test: /\.(njk|nunjucks)$/,
  loader: 'nunjucks-loader',
  query: {
    root: __dirname + '/pages',
    opts: {
      tags: {
        variableStart: '{$',
        variableEnd: '$}'
      }
    }
  }

from nunjucks-loader.

at0g avatar at0g commented on September 22, 2024

v2.4.8 reverts the changes in PR #48 and fixes this mess.
Will look at a 3.x branch for the move to loader utils 1.x

from nunjucks-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.