[BUG] Improve feed view scrolling performance and behaviour about leomard

[Athlon007]

I think my only issue with the current FeedView changes is the page's sidebar is still visible, even in the smallest window width. I don't think page's sidebar is important enough to show all the time. In other views - that's not a problem, as the person's/community's sidebar is moved to the top of main column, but for Feed - that was never implemented, as page sidebars can be very, very long.

With that being said, good job and thanks for the changes :)

[Athlon007]

Yeah, but I know my code Swift was meh at the very least. I'll definitely borrow couple of tricks you have added in the future UI code.

I'll think about how to approach the page sidebar tomorrow. I already have something in my head that will work.

[BraveSentry]

Actually will keep this issue open for now, since we need to apply scrolling optimizations to Community feed.

Thanks for that, as I have a scrolling related minor issue: When the mouse pointer is in the same window part as the feed but in the blank area left of the feed, scrolling does not work. I can only scroll when the mouse pointer is directly on the feed.

[boscojwho]

I did a quick test and removed GeometryReader and ScrollViewReader from FeedView, but scrolling performance felt relatively the same.

[boscojwho]

Seems like the solutions are pretty simple:

1. Push some post loading calls onto some background tasks in FeedView. In particular, the system hasher is using quite a bit of CPU time when processing PostView.
2. SessionStorage appears to be causing some long main thread hangups on launch.

This is probably the top issue affecting my personal enjoyment of this app, so I might dive into this later tonight or possibly tomorrow =D

[boscojwho]

I think my only issue with the current FeedView changes is the page's sidebar is still visible, even in the smallest window width. I don't think page's sidebar is important enough to show all the time. In other views - that's not a problem, as the person's/community's sidebar is moved to the top of main column, but for Feed - that was never implemented, as page sidebars can be very, very long.

With that being said, good job and thanks for the changes :)

No worries =) Very fun to work on a Mac app and something new

Ohh, that explains why FeedView implementation looked slightly different from the others haha. I almost never use Mac apps in narrow width (angrily shakes fist at new System Settings). Definitely a design issue to be dealt with separately.

[boscojwho]

Got scrolling performance to a better level, and reduced the number of times where scroll view doesn't catch a swipe gesture because it blocked the main thread.

• Also moved a post-processing task in PostUIView off the main thread (need to clean this up before I make a PR). This seems like this was causing quite a bit of the missed swipes.

[boscojwho]

Actually will keep this issue open for now, since we need to apply scrolling optimizations to Community feed.

[boscojwho]

Actually will keep this issue open for now, since we need to apply scrolling optimizations to Community feed.

Thanks for that, as I have a scrolling related minor issue: When the mouse pointer is in the same window part as the feed but in the blank area left of the feed, scrolling does not work. I can only scroll when the mouse pointer is directly on the feed.

Ah yes, good point, I noticed that too. That's because the Feed view has a maximum width, so that blank area isn't scrollable at the moment. I guess at the very least, we could make the Feed view be leading aligned, so that blank space to the left gets taken out. Perhaps @Athlon007 has more ideas here =)

[Athlon007]

Actually will keep this issue open for now, since we need to apply scrolling optimizations to Community feed.

Thanks for that, as I have a scrolling related minor issue: When the mouse pointer is in the same window part as the feed but in the blank area left of the feed, scrolling does not work. I can only scroll when the mouse pointer is directly on the feed.

Ah yes, good point, I noticed that too. That's because the Feed view has a maximum width, so that blank area isn't scrollable at the moment. I guess at the very least, we could make the Feed view be leading aligned, so that blank space to the left gets taken out. Perhaps @Athlon007 has more ideas here =)

It's definitely something worth to take a look at, however, not for 0.2. I consider 0.2 feature locked.