Comments (4)
I have commented on this i think, but just in case - we can't move this into __render_where, because the wrapping methods would typically prepend " having", " where" and if there are no clauses at all, we should return null, that's why this check is done on the top-level.
from dsql.
not sure I understood your comment :)
$ret = $this->__render_where('where');
return $ret ? implode(' or ', $ret) : null;
should do that same thing.
from dsql.
Yeah, but I've read in the code developer guidelines to return from methods early if possible.
It's not a huge deal really. Plus all of the _render() methods have the same code to return 'null' if their presence is not needed. Perhaps we can even move it to render() method, but I'm not sure at this time if it can create more problems or not.
When in doubt, leave as-is.
from dsql.
I agree.
from dsql.
Related Issues (20)
- is there a "rows_affected()" or equivalent for dSQL queries? HOT 7
- Implement exprNow() method HOT 2
- PHP has reserved all method names with a double underscore prefix for future use. HOT 1
- Legal rollback of atomic method HOT 8
- Segfault in CI tests / GH Actions HOT 1
- Connection_Counter should not return iterator HOT 3
- Enable strict types for dsql repo
- AgileToolKit SSL/TLS HOT 1
- See our "Awesome Queries" gallery HOT 1
- Remove reference property HOT 3
- Replace Connection with DBAL
- Expression getCastValue turns everything into a string. HOT 7
- No wrapping parenthesis around nested conditions HOT 3
- Add CI testing with Oracle DB
- Add CI testing with MSSQL
- Fix and reintroduce support for 4000+ bytes CLOB/BLOB for Oracle HOT 1
- Query cannot render complex condition in the HAVING clause
- Add space before Expression in 'set' value HOT 2
- Cast bool params to int in getDebugQuery HOT 1
- Status/result of non-select Query HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dsql.