GithubHelp home page GithubHelp logo

Comments (4)

JohannesRudolph avatar JohannesRudolph commented on July 21, 2024 1

I wouldn't mind if you just bumped a minor (e.g. 1.x) on each revision that doesn't contain breaking changes). The problem with this (and many other docker images) is that it's not 100% reproducible, e.g. the -js version installs node 6.x

RUN curl -sL https://deb.nodesource.com/setup_6.x | bash -
RUN apt-get install -y nodejs && npm install -g npm@latest

So the version on Docker Hub depends on the time the image was built.

On the other hand, just monotonically increasing the version would be fine with me as well. It's just meant to ensure people can pull an immutable image version from docker hub by tag.

from docker-chromium-xvfb.

mark-adams avatar mark-adams commented on July 21, 2024

Sure! Do you have a suggestion for how you'd version them?

Most of the images that I've seen on Docker Hub tend to follow the underlying version of a framework or major software release. In this case, I'm already doing that with Python 2 vs Python 3 and I'd certainly be open to doing that with the JS images.

Any ideas are very much welcome!

from docker-chromium-xvfb.

vkruoso avatar vkruoso commented on July 21, 2024

Just found the image and it works great for JS tests. This versioning scheme would be great. Otherwise, to have reproducible builds we need to build the image on our own. What can we do to help you on this?

from docker-chromium-xvfb.

mark-adams avatar mark-adams commented on July 21, 2024

I started some work on this over the past few days: https://hub.docker.com/r/markadams/chromium-xvfb-js/tags/

The JS image now contains tags for 6.x and 7.x versions of Node and the exact versions are pinned in the Dockerfiles. Next, I'll probably create some tags for the minor versions as well.

from docker-chromium-xvfb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.