GithubHelp home page GithubHelp logo

Comments (6)

atmos avatar atmos commented on July 20, 2024

You're going to need access to their code and know where to put it. I'm planning on having the incoming webhooks check your secret tokens soonish.

from heaven.

ebeigarts avatar ebeigarts commented on July 20, 2024

Secret tokens sounds good, but if someone exposes the secret than you're vulnerable. What about public github projects? Isn't it possible to just create public github repo and modify Capfile to do something bad (send HEROKU_API_KEY, DEPLOYMENT_PRIVATE_KEY to someone)? I think it would be better if new repositories were disabled by default and you needed to run something like heroku run heaven enable owner/repo

from heaven.

atmos avatar atmos commented on July 20, 2024

I'm working on bring this to hubot-deploy and it likely won't land in heaven.

from heaven.

heim avatar heim commented on July 20, 2024

Just wanted to chime in on this issue, I've made some changes to our heaven-fork that checks the secret token provided from the webhook. The code is in no way clean or tested, but if it stil interesting to get it merged into this repo I can put down an effort to make a PR.

from heaven.

atmos avatar atmos commented on July 20, 2024

@heim that'd be awesome

from heaven.

heim avatar heim commented on July 20, 2024

@atmos I'll put it on my list, guess I'll be able to do it over the weekend. Haven't done any Rails programming for a couple of years, but I guess it's just like learning to ride a bike. 🚲

from heaven.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.