Identify Portal Participants about teletype

[nathansobo]

I really love your organized mind.

[jasonrudolph]

#87 accomplishes most of what we outlined in the issue body above. 🤘

@as-cii @nathansobo: Do you think we should pursue the remaining items, or would you want to hold off on those items until we implement something like the buddy list UI we've been discussing?

[nathansobo]

I think we may as well finish the notifications and ensure our error handling is good before proceeding.

[as-cii]

I think we already show an error when something goes wrong when authenticating. As for notifications, the only one we haven't implemented is:

As a guest, when I join a portal, I see a notification saying, "You're now collaborating with @" [3]

It should be pretty straightforward to add, but I am not sure we need it since guest users knows who they are connecting to. I am open to adding it, but I think we should go ahead and staff-ship what we have currently. Thoughts? 💭

[jasonrudolph]

As a guest, when I join a portal, I see a notification saying, "You're now collaborating with @" [3]

It should be pretty straightforward to add, but I am not sure we need it since guest users knows who they are connecting to.

We discussed this on our planning call today and agreed that we should skip this ☝️ for now.

With that in mind, I'm gonna close this issue.

/xref https://github.com/github/atom-log/commit/14587eb1e7e2c3ee9aaf54de11c559884b4e75aa#diff-354c56c08bc3626e67f6ba3f207a7920R66