Comments (10)
It's just that the guide is focused, correct? Likely because it is opened last.
from welcome.
It's just that the guide is focused, correct?
The editor was focused in this case I believe.
from welcome.
I guess I'm confused. Can you give me exact steps? My assumption:
- open welcome
- it opens welcome in left pane then guide in right pane; at this point the right pane has focus
- cmd+n
- opens new buffer in right pane
from welcome.
Can you give me exact steps?
- Open Atom for the first time
- That screenshot is what I saw
from welcome.
Here is the beginning of the open-initial-empty-buffer code, and here is the handler in the renderer process. The entire way through, this initial buffer opening is implicit via a null path. My thoughts right now are:
- I would like this to be explicit for clarity. It wasnt very easy to follow through main -> app -> window -> IPC.
- I want to get metadata through to the renderer handler indicating that the buffer is or is not the initial empty buffer
- I want to have an event like
atom.onWillOpenInitialEmptyBuffer({cancel})
wherecancel
will allow a package to not open said buffer.
Any opinions on this approach? @kevinsawicki @nathansobo?
from welcome.
I don't have a ton of context on this but it seems reasonable. So to clarify, the issue is that we're opening an initial empty buffer when we want to only show the welcome screen and you're seeking to preempt it?
from welcome.
when we want to only show the welcome screen and you're seeking to preempt it
Yeah
from welcome.
Sounds good.
from welcome.
Any opinions on this approach?
I would like this to be explicit for clarity.
👍 This would be great, this code path is very hard to follow currently and easy to break on the browser process side.
I want to get metadata through to the renderer handler indicating that the buffer is or is not the initial empty buffer
It would be great if we could get this to be 100% a render process concern
I want to have an event like atom.onWillOpenInitialEmptyBuffer({cancel})
I'm down for an API, though I think having the untitled buffer behind the welcome guide is kind of nice, once you digest the welcome information and close it, you got a buffer ready to go.
from welcome.
I think having the untitled buffer behind the welcome guide is kind of nice, once you digest the welcome information and close it, you got a buffer ready to go.
The only way to do that today without changing browser code is to add the welcome panes on a long timeout (> 500ms).
Check out the PR at atom/atom#5812. I think it would be useful to pass some information indicating whether it's opening the initial buffer. It has upsides elsewhere too: This person could disable it in their init script, we could make an option for it, etc.
from welcome.
Related Issues (19)
- question: is there a get 'guide' to compile it and try it ? HOT 4
- Welcome.md first impressions HOT 4
- Welcome adds time to startup, even though it is never expected to be used again HOT 1
- Platform detection (was: Welcome on Windows is incorrect.) HOT 2
- Update text for Beta users HOT 4
- Platform detection regression (key combinations on Windows incorrect)
- Hard to find the welcome page HOT 3
- Add stylesheet examples HOT 1
- Failed to activate the welcome package HOT 1
- Opening Theme Manage from Welcome Guide
- welcome.showOnStartup does not effect dev mode HOT 1
- Overflow problems when opening some items HOT 2
- Cannot scroll back up after expanding sections in the Welcome Guide HOT 2
- The guide points to a non-existent menu in Windows and Linux HOT 2
- Welcome automatic show HOT 2
- Telemetry prompt is not shown again if dismissed the first time HOT 1
- Checkbox label doesn't have `for` attribute. HOT 1
- crashed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from welcome.