GithubHelp home page GithubHelp logo

Comments (10)

attzonko avatar attzonko commented on August 30, 2024

There was a recent fix to the mattermostdriver package related to websocket connection. Could you try with the latest mattermostdriver from the HEAD of that repo?

from mmpy_bot.

unode avatar unode commented on August 30, 2024

As we are now using a different driver, could you please re-test if the latest version from the main branch still displays this bug and report here?
Thanks!

from mmpy_bot.

cristianjuve avatar cristianjuve commented on August 30, 2024

We're receiving the same issue after upgrade to mattermost 7.1.2 from 5.38.2.
Error with mmpy-bot=2.0.2
Captura de pantalla 2022-09-13 a les 16 35 13
If we enable debug mode then it works.

Error with mmpy-bot=2.1.0
Captura de pantalla 2022-09-13 a les 16 37 02
In this case if we enable debug mode it doesn't work.

We're using a custom plugin and we don't understand what's the function that is failing on our code. I share with you part of our code to try to find where is the issue.
Captura de pantalla 2022-09-13 a les 16 40 36

Thanks!

from mmpy_bot.

unode avatar unode commented on August 30, 2024

In the first case, there's a problem in mattermostdriver that was since fixed but an upgrade is required.
Regarding the plugin.initialize() error in 2.1.0, there was an API change that introduced another argument (plugin_manager).

See the difference in the function signature between 2.0.2

def initialize(self, driver: Driver, settings: Optional[Settings] = None):

and 2.1.0

def initialize(

from mmpy_bot.

cristianjuve avatar cristianjuve commented on August 30, 2024

How can I fix the issue with mattermostdriver? upgrading mattermost(version?)?? or mmpy-bot?
Regarding the API changes, how should I initialize the Bot? I'm not sure how to pass the plugins arg Optional[Union[List[Plugin], PluginManager]]

Captura de pantalla 2022-09-13 a les 18 04 48

from mmpy_bot.

unode avatar unode commented on August 30, 2024

You can continue using:

plugins=[SealPlugin()]

but you need to update the signature of def initialize(driver, plugin_manager, settings): in your plugin.

You don't need to use your own PluginManager instance unless you want to customize/override its behavior.

from mmpy_bot.

unode avatar unode commented on August 30, 2024

Please see #306 for a follow up on the mattermostdriver issue.

I believe the issue is solved by embl-bio-it/python-mattermost-autodriver@b699cb9 but a version of mmpy_bot that uses this fix hasn't been released yet.
Please try the latest code from the main branch and lets us know if the problem is gone.

I'm using it on Mattermost 7.1.2 without problems.

from mmpy_bot.

cristianjuve avatar cristianjuve commented on August 30, 2024

it works!! thnks! :)

from mmpy_bot.

unode avatar unode commented on August 30, 2024

Closing as resolved in main.

from mmpy_bot.

attzonko avatar attzonko commented on August 30, 2024

Just made release 2.1.1 from the latest main

Thanks for confirming the fixes work for you @cristianjuve

from mmpy_bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.