[Bug]: Install script putting env sourcing in .bash_profile instead of .bashrc about atuin

[Colonial-Dev]

Oh, this script is from cargo-dist, not you guys - was wondering why I couldn't find it in the repo... I'll drop them an issue.

[ellie]

Thanks for reaching out to cargo-dist! I'll close this one as it seems like they're on it, happy to reopen if that's not the case. Our install script wraps the cargo-dist one to do a few extra things, so we could potentially add something there too.

[Colonial-Dev]

It looks like this particular snippet is the problem:

# Find the first file in the array that exists and choose
# that as our target to write to
for _rcfile_relative in $_rcfiles; do
    _home="$(print_home_for_script "$_rcfile_relative")"
    local _rcfile="$_home/$_rcfile_relative"

    if [ -f "$_rcfile" ]; then
        _target="$_rcfile"
        break
    fi
done

The rcfile candidates are .bash_profile .bash_login .bashrc, which means .bash_profile is picked first and the others are simply ignored.

For what it's worth, I checked the way rustup does it, and they opt to inject the sourcing into both files.

add_install_dir_to_path execution with -x/trace on

+ add_install_dir_to_path '$HOME/.atuin/bin' /var/home/colonial/.atuin/bin/env '$HOME/.atuin/bin/env' '.bash_profile .bash_login .bashrc' sh + local '_install_dir_expr=$HOME/.atuin/bin' + local _env_script_path=/var/home/colonial/.atuin/bin/env + local '_env_script_path_expr=$HOME/.atuin/bin/env' + local '_rcfiles=.bash_profile .bash_login .bashrc' + local _shell=sh + '[' -n /var/home/colonial ']' + local _target + local _home + for _rcfile_relative in $_rcfiles ++ print_home_for_script .bash_profile ++ local script=.bash_profile ++ local _home ++ case "$script" in ++ _home=/var/home/colonial ++ echo /var/home/colonial + _home=/var/home/colonial + local _rcfile=/var/home/colonial/.bash_profile + '[' -f /var/home/colonial/.bash_profile ']' + _target=/var/home/colonial/.bash_profile + break + '[' -z /var/home/colonial/.bash_profile ']' + local '_robust_line=. "$HOME/.atuin/bin/env"' + local '_pretty_line=source "$HOME/.atuin/bin/env"' + '[' '!' -f /var/home/colonial/.atuin/bin/env ']' + say_verbose '/var/home/colonial/.atuin/bin/env already exists' + '[' 1 = 0 ']' + grep -F '. "$HOME/.atuin/bin/env"' /var/home/colonial/.bash_profile + grep -F 'source "$HOME/.atuin/bin/env"' /var/home/colonial/.bash_profile + '[' -f /var/home/colonial/.atuin/bin/env ']' + local _line + '[' sh = fish ']' + _line='. "$HOME/.atuin/bin/env"' + say_verbose 'adding . "$HOME/.atuin/bin/env" to /var/home/colonial/.bash_profile' + '[' 1 = 0 ']' + ensure echo '' + echo '' + ensure echo '. "$HOME/.atuin/bin/env"' + echo '. "$HOME/.atuin/bin/env"' + return 1

[Colonial-Dev]

Further testing:

• AlmaLinux 9 (RHEL compatible, recent install for a cPanel server): same issue
• Fedora Toolbox container: same issue
• Debian container: works fine

Perhaps something upstream in the RPM family is to blame...