GithubHelp home page GithubHelp logo

PHP 8.1 Compatibility about aura.sql HOT 8 CLOSED

srjlewis avatar srjlewis commented on July 16, 2024
PHP 8.1 Compatibility

from aura.sql.

Comments (8)

pmjones avatar pmjones commented on July 16, 2024 1

@kenjis fine by me!

from aura.sql.

kenjis avatar kenjis commented on July 16, 2024

See auraphp/Aura.Cli_Kernel#12 (comment)

  • The Aura 3.x series was for PHP 5.6 and later.
  • The Aura 4.x series is for PHP 7.2 and later.
  • I imagine a 5.x series, if you want to start one, should be for 8.0 (or perhaps 8.1?) and later.

from aura.sql.

kenjis avatar kenjis commented on July 16, 2024

Personally, I think it would be good to set the Aura 5.x requirement to PHP 8.1 or later.

from aura.sql.

srjlewis avatar srjlewis commented on July 16, 2024

Yes I agree, 5.x should start a 8.1, as current 3.* does work fine for PHP 8.0, as PHP 8.1 is now starting to enforce typing from the core of PHP the 5.x series can now be fully typed.

If you are happy with that, I will branch from 3.x-actions as it has updates to phpUnit.

As a side note I will be having a look at aura.sqlquery and aura.sqlschema, but for the meantime they seem to be working fine with PHP 8.1 so far but not heavily tested

from aura.sql.

kenjis avatar kenjis commented on July 16, 2024

@pmjones @harikt @koriym
Are you okay Aura 5.x requires PHP 8.1 or later?

from aura.sql.

srjlewis avatar srjlewis commented on July 16, 2024

Ok I have done all the changes, everything is typed, tests have been fixed, github actions has been updated.

All test are passing local and on github actions.

I will wait for you to branch it, then make a PR to the new branch.

from aura.sql.

kenjis avatar kenjis commented on July 16, 2024

I created 5.x branch from 3.x-actions.
https://github.com/auraphp/Aura.Sql/tree/5.x

It seems #191 is missing in 5.x.

from aura.sql.

srjlewis avatar srjlewis commented on July 16, 2024

I have created pull request #193 to 5.x branch

from aura.sql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.