error TS1110: Type expected about dependency-injection

[EisenbergEffect]

@DrSammyD Would you be able to help us resolve this?

[DrSammyD]

I'll take a look tonight.

[bigopon]

Probably this line

dependency-injection/src/resolvers.ts

Line 79 in 98c0044

}, ...TImpl[]];

caused it. It seems to be an issue with TS, since VsCode does not reports error but tsc fails.

For now, I think we should change it to something like this:

export interface StrategyState<
  TBase,
  TImpl extends Impl<TBase> = Impl<TBase>,
  TArgs extends Args<TBase> = Args<TBase>
  > {
  /**
   * For typings purposes, this is done as { get: StrategyFunctor } | TImpl
   * But it should be understood, and used as [{ get: StrategyFunctor }, ...TImp[]]
   */
  [Strategy.array]: ({
    get: (
      container: Container,
      key: PrimitiveOrDependencyCtor<TBase, TImpl, TArgs>
    ) => TImpl
  } | TImpl)[];
  [Strategy.alias]: any;
}

[DrSammyD]

Did typescript break this? How was it ever building?

[bigopon]

@DrSammyD hmm, i'm not sure. Maybe it nevered actually built with tsc?

[DrSammyD]

@bigopon I mean, it must have or the this wouldn't have passed PR checks and this...

dependency-injection/dist/aurelia-dependency-injection.d.ts

Lines 65 to 68 in 98c0044

	[Strategy.array]: [{
	get: (container: Container, key: PrimitiveOrDependencyCtor<TBase, TImpl, TArgs>) => TImpl;
	}, ...TImpl[]];
	[Strategy.alias]: any;

... wouldn't have ever been generated when compiling with typescript and running the tests.

dependency-injection/package.json

Line 35 in 98c0044

"test": "cross-env rimraf dist && tsc && karma start --single-run",

dependency-injection/package.json

Line 103 in 98c0044

"typescript": "^3.4.1"

So the issue only shows up when old typings conflict with the new ones? Should the other projects update to the new typings?

Would this fix actually be generically fix or are we going to have to continually change these typings to match what other projects are expecting?