Comments (10)
Yep yep yep. For sure this is an issue. Haha.
The circle-ci files I have here were copied from another project and I have been meaning to fix it. It should be a simple fix, but as you mentioned in the video, I wanted to take this opportunity to test out GH actions. So Im all on board for this.
For the time being, we can remove the Circle CI folder. And then I'll add some actions as I can. Actually working on something similar at work, so I was going to learn it first, then implement it here.
from vuetensils.
Yes it can. That's how I have it set up. And TS can also do it's thing with JSDoc, so I have the complier run over the code to catch any mistakes. It's pretty handy, and I like that I don't have to wrtie TS.
from vuetensils.
Related, had an idea:
from vuetensils.
Hey @TheJaredWilcurt Im finally getting into this and testing out some stuff. Trying to run eslint I keep getting this error:
No files matching the pattern "src/components/VAction" were found.
Please check for typing mistakes in the pattern.
That mean anything to you? Seems to have something to do with VAction being a .vue file. I thought I had eslint setup to handle these fine before.
from vuetensils.
No files matching the pattern "src/components/VAction" were found. Please check for typing mistakes in the pattern.
Hi @Stegosource , it looks as though those errors are being generated by the Typescript compiler and not ESLint. It also throws some other errors related to adding non-native properties to an HTMLElement.
If you change your build command in package.json to npm run build:umd && npm run build:es && npm run build:unpkg
it clears up those errors. I'm not sure if you were planning on generating some Typescript definitions for the project or something like that. If that's the case, in the short term at least that gets you closer to a working CI/CD workflow.
from vuetensils.
Ok I see what's going on now with those Typescript definitions. I was able to clear up those errors by including a Vue shim. There is still an issue with some of the type annotations in src/directivees/clickout.js
which I haven't had the time to dive into. Here's a branch so you can see the module resolution fixes though:
https://github.com/volkipp/vuetensils/tree/lint-fix
from vuetensils.
@volkipp That's super helpful. I am using TS to generate type definitions with the goal of providing consumers some nicer intellisense. I got as far as to know I needed a shim, but did not sort out how to set that up.
Also, good catch on that build command. My silly mistake using &
instead of &&
. I was wondering why it never caught the errors.
Thanks! The other type errors are easy enough to fix. I can get on that soon.
from vuetensils.
No problem @Stegosource ! Glad that was helpful. I only noticed the &&
thing because I've done the same thing way too many times. :D
from vuetensils.
The linter should be happy again with this pull request #96
I also added in those other types so the TS definition files get generated now too. It looks like there's just one test failing and that has to do with a change to VBtn
from vuetensils.
Supposedly Visual Studio and VSCode can infer types from JSDoc comment blocks in the same way as it can from TS, and can even offer descriptions of each argument.
from vuetensils.
Related Issues (20)
- Intersect question: how to observe many child elements in v-for loop HOT 3
- [feature] - add complementary role to VAlert HOT 7
- Feature request? tree component? HOT 2
- Error "export 'version' was not found in 'vue' HOT 6
- Feature: Focusout HOT 2
- Import errors in Vue2 with Vite HOT 7
- [Vue warn]: Error in render: "TypeError: errors.get is not a function" HOT 5
- [Feature Request] allow localization of the buttons of the datepicker HOT 5
- [Feature Request] i18n HOT 1
- [Feature Request] VDate: allow inline usage HOT 3
- vue 3 support ? HOT 2
- Website docs don't show any examples anymore HOT 5
- VAlert dismissible doesn't work with scoped css HOT 5
- Vuetensils: TypeError: Object(...) is not a function HOT 5
- Drawer sliding animation HOT 4
- Browser compatibility HOT 7
- [Feature Request] Support Vue 2.7 by upgrading vue-demi to ^0.13 HOT 6
- Failed to resolve entry for package "vuetensils" HOT 3
- Input still has error styling after changing error conditions HOT 9
- Enable class customisation for individual notifications HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vuetensils.