Date assertion after and before java LocalDateTime about zerocode

[ispandey81]

Hi, I would like to contribute to this project. I am a beginner to open source contribution. Please let me know if i can work on any issue or enhancement.
Thanks,
Indra

[authorjapps]

Sure, Sounds cool @ispandey81 ,
You can please pick this issue or any other issue which you think is good for the first time. I would suggest to pick a simpler one. This issue is also a simpler one.

Kindly read the CONTRIBUTING.MD which will make things easy.
And then could you please join our mailing/gitter lists below.

• Join the collaborators mailing list
  https://groups.google.com/forum/#!members/zerocode-automation

• Join Gitter room
  https://gitter.im/zerocode-testing/help-and-usage

[ispandey81]

Hi, I apologise for not being able to start work on this issue. Happy for it to be picked up by someone else. Will look for a different issue from the list. Cheers, Indra

…

On Tue, Jun 4, 2019 at 5:49 AM authorjapps ***@***.***> wrote: @jbonn360 <https://github.com/jbonn360>, thanks, please proceed. Let us know in case you need any heads up please! @ispandey81 <https://github.com/ispandey81>, hope you are ok with this as it's been long time the ticket has not been worked upon! You can review the PR for your learning(in case it interests you)! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AHVKOUAA7ZZVTTGXLMOGEYTPYWGXLA5CNFSM4CLBL43KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2ZKRI#issuecomment-498439493>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHVKOUD63LFTZ6YILNSGH23PYWGXLANCNFSM4CLBL43A> .

[jbonn360]

Hi,

I'd like to work on this issue if that's ok. Please assign it to me.

Thanks

[authorjapps]

@jbonn360, thanks, please proceed. Let us know in case you need any heads up please!

@ispandey81, hope you are ok with this as it's been long time the ticket has not been worked upon!
You can review the PR for your learning(in case it interests you)!

[jbonn360]

@authorjapps Cheers! One question, should we support any other datetime formats apart from ISO8601 (as in '2015-09-14T09:49:34.000Z')?

[jbonn360]

@ispandey81 Thank you Indra 🙏

[authorjapps]

PR looks great with great test coverage! Thanks @jbonn360.

Version 1.3.9 will contain this feature.

...any other datetime formats apart from ISO8601 (as in '2015-09-14T09:49:34.000Z')?

Should be good for now as this format is most widely used 👍

[authorjapps]

@jbonn360 , can you help us here to amend this PR or raise a new-PR(better) please? 🙏

We need to amend these tokerns to be consistent with the simillar tokens already in use.
Apologies for the late intimation.

$DATE.BEFORE to $LOCAL.DATETIME.BEFORE to avoid confusion in the future.
Also same for
$DATE.AFTER to $LOCAL.DATETIME.AFTER

Thanks for understanding!

[jbonn360]

@authorjapps no worries, I'll submit a new PR

[authorjapps]

Feature available in version 1.3.9 and higher.