light events not triggering on scene changes about home-controller

[brandongoode]

It should emit the same events for the scene commands. Is it possible for you to run your code with the environment variable DEBUG=home-controller* and provide the output when you trigger the scene?

[siburny]

I can confirm this as well. Message that is sent from device (ack) is not recognized,

In my case on/off switch sends this:

command1:"11"
command2:"01"
extended:false
gatewayId:"aabbcc"
hopsLeft:0
id:"ffffff"
maxHops:1
messageType:3
raw:"0250ffffffaabbcc611101"
type:"50"

Notice messageType is 3, which is direct ACK (not broadcast). Fix is easy, will submit a PR.

[siburny]

@brandongoode Your comment here https://github.com/automategreen/home-controller/blob/master/lib/Insteon/Light.js#L416 says "ack doesn't have group". Maybe they changed something, and group ack does have a group :)

[brandongoode]

@siburny Good catch and thanks in advance for the PR. The comment is reference to standard direct message.

[brandongoode]

You could us the handleAllLinkBroadcast for type 3. From the Insteon Dev Guide: 011 = ACK of ALL-Link Cleanup Message. I think it would be the same logic as type 2. [edited typo]

[siburny]

Sounds good

[siburny]

@jonn26 we just pushed a fix. Can you please test it on your setup?

[jonn26]

I can confirm I am now seeing light events on scene changes. @siburny & @brandongoode thanks for the quick fix!