Comments (9)
I have managed to make a comparison by running the hlky repo on colab (https://github.com/daswer123/stable-diffusion-colab). It's not ideal since the masks are not exacly the same, but I think that it illustrates the differences.
The anon-hlhl implementation that was merged on the hlky webui seems to blend better the masked part the image with its surroundings, while the current implementation here often gives this "image inside an image" effect where the masked part loses connection with the surrounding context.
Seeds: 42, 43, 44, 45
Denoising strength: 1
Euler_a
20 steps
Remaining settings left as default
from stable-diffusion-webui.
Thank you so much @AUTOMATIC1111! Your rigorous test settles it: it was probably all just cherry picking and superstition on my end.
It seemed reasonable to assume that doing the masking procedure for each iteration of the denoising process would give better results, but that doesn't seem to be the case.
The new CFGDenoiser
implementation allows me to keep experimenting with this. I will do that and let you know if I find something that improves inpainting quality.
from stable-diffusion-webui.
The alternative implementation seems to be different and give better results; I have implemented it in PR #36 for your consideration.
from stable-diffusion-webui.
i tested both, its hard to tell, you might get lucky with resut and think wow it works better, i dont think any of those are using the proper inpainting model from here #20
Not sure how that model would change the results but its working good without it so far , k_euler_a gets best alignment with original image, other ones not so much
from stable-diffusion-webui.
I think that you are be right, it might have been pure luck. I have also gotten great results with euler a
and no blurring.
Maybe we should run a side by side test with the same settings to confirm that no qualitative difference exists?
from stable-diffusion-webui.
this one has also inpainting but its without proimpt which is incomplete i think , tried to remove eyes and it wont do it, i think SD inpainting wont work without prompt
https://github.com/shinomakoi/sd-dreamer
You mean same seed for inpainting , theres no way you can draw the same looking mask in both uis , i had great results with this repo inpainting but the masking blurring code is reversed, its applied to inpainted image insteead of original image to blur the edges and gives very harsh edges https://i.postimg.cc/3rfxrP2J/inp.jpg
from stable-diffusion-webui.
Even though perfectly drawing the same mask two times would be impossible, a rough comparison would still be valuable imo.
I would do it myself, but for some reason I can't get the hlky fork or the anon-hlhl fork to run anymore in optimized mode, so I can't do the test.
I agree that the edges are looking rough on the implementation here.
from stable-diffusion-webui.
from stable-diffusion-webui.
Results for what I had originally:
Results for denoising via CFGDenoiser:
All with same seeds and everything.
Defaults are very different in both repos so comparing at defaults is as meaningful as you consider it.
from stable-diffusion-webui.
Related Issues (20)
- AttributeError: 'UiControlNetUnit' object has no attribute 'enable'[Bug]: at last version HOT 10
- ERROR Calling AnimateDiff HOT 10
- [Bug]: Can't create venv at the first launch HOT 2
- RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument weight in method wrapper_CUDA___slow_conv2d_forward)[Bug]: HOT 2
- Torch is not able to see GPU HOT 6
- [Bug]: sd-webui-prompt-all-in-one extension is glitching the prompt bar HOT 2
- [Bug]: LORA's with .zip extension do not display in list with other LORA's HOT 1
- [Feature Request]: HOT 5
- [Feature Request]: Image Formats passed to api calls HOT 1
- [Feature Request]: Add GPEN to Face Restoration models HOT 1
- [Bug]: Error
- [Bug]: AttributeError: 'NoneType' object has no attribute 'lowvram' -- Clean install on Mac
- [Bug]: --share not work with paperspace HOT 1
- [Bug]: Error loading specific Upscalers: "RuntimeError: PytorchStreamReader failed locating file constants.pkl: file not found" HOT 1
- [GET THE OLD SAMPLING METHOD BACK]: HOT 15
- [Bug]: Prompt in textarea cannot be drag and drop since 1.9.0 HOT 3
- [Bug]: SDXL inpainting results in 'NansException' occurred with 1st settings. Error when VAE is present on MacOS
- [Bug]: HOT 9
- Can't load PonydiffusionXL HOT 4
- [Bug]: Stuck on Installing requirements
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stable-diffusion-webui.