Comments (3)
I think I know what's going on here.
The unloading mechanism we've defined here unloads Gutenberg in the post edit context, which is surely the most important place for this to happen. However, it allows Gutenberg to run in every other context since I think gutenberg_can_edit_post_type
governs only the post edit screen and does not address other Gutenberg side-effects such as menu modification etc etc ... I bet, for instance, that the Gutenberg menu is present in wp-admin.
Ideally, we want the user experience to be the same independent of whether Ramp is running with the plugin not activated, the plugin activated and eventually 5.0. This would mean adding functionality to remove things like menus etc etc ... I'll see if I can work on something like that.
from gutenberg-ramp.
@rogertheriault if you're working on stuff this week could you have a look at the above?
Also -- the reason you're getting No route was found matching the URL and request method
is because that post type probably doesn't declare show_in_rest => true
which is required for Gutenberg support ... we might want to check this before attempting to turn on Gutenberg for a post type since nothing will work in its absence.
from gutenberg-ramp.
@mattoperry tempting, but unfortunately I've been stuck with some other tasks at home that have kept me busy this week.
Great point on the show_in_rest.
from gutenberg-ramp.
Related Issues (20)
- In settings, improve checkbox UI for enabling custom post types HOT 6
- Cross linking an issue in regards to additional editing options HOT 1
- Suggested enhancements - to plugin or to documentation HOT 4
- generalize criteria for GB loading HOT 8
- Disable 'try Gutenberg' banner in wp 4.9.8, if using Ramp HOT 7
- Admin Alert when Gutenberg is off - dismissible forever HOT 1
- Autoloading ramp options HOT 3
- Does not support 'fallback' mode HOT 2
- allow opt-in to Gutenberg by post/page slug or tag HOT 2
- Bug: Gist embedding not displaying in editor HOT 1
- wpcom_vip_load_gutenberg doesn't allow meta boxes to be loaded HOT 3
- Disable Ramp when Gutenberg version requirements aren't met HOT 3
- All options in the UI should be greyed out in the cases where Ramp sets Gutenberg to always or never load
- Make Ramp + Classic Editor play nicer together HOT 2
- Make it clearer how to enable Gutenberg for all post types HOT 1
- Add some clarity to the documentation about Gutenberg requirement HOT 1
- "Greater Than" HOT 4
- Ability to modify admin screen access
- The UI isn't displaying at all. HOT 1
- Plugin always loads classic-editor when classic-editor plugin is installed HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg-ramp.