GithubHelp home page GithubHelp logo

Comments (3)

mattoperry avatar mattoperry commented on June 28, 2024

I think I know what's going on here.

The unloading mechanism we've defined here unloads Gutenberg in the post edit context, which is surely the most important place for this to happen. However, it allows Gutenberg to run in every other context since I think gutenberg_can_edit_post_type governs only the post edit screen and does not address other Gutenberg side-effects such as menu modification etc etc ... I bet, for instance, that the Gutenberg menu is present in wp-admin.

Ideally, we want the user experience to be the same independent of whether Ramp is running with the plugin not activated, the plugin activated and eventually 5.0. This would mean adding functionality to remove things like menus etc etc ... I'll see if I can work on something like that.

from gutenberg-ramp.

mattoperry avatar mattoperry commented on June 28, 2024

@rogertheriault if you're working on stuff this week could you have a look at the above?

Also -- the reason you're getting No route was found matching the URL and request method is because that post type probably doesn't declare show_in_rest => true which is required for Gutenberg support ... we might want to check this before attempting to turn on Gutenberg for a post type since nothing will work in its absence.

from gutenberg-ramp.

rogertheriault avatar rogertheriault commented on June 28, 2024

@mattoperry tempting, but unfortunately I've been stuck with some other tasks at home that have kept me busy this week.

Great point on the show_in_rest.

from gutenberg-ramp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.