Custom CSS: show_all_rev doesn't return all revisions anymore about jetpack

[mattoperry]

I can't reproduce this. In fact, the "show more" button does indeed reveal extra CSS revisions for me when I follow your instructions. However, I discovered the following two problems in this area related to JetPack_Public_CSS::revisions_meta_box:

1. The call to wp_revisions_to_keep on line 891 produces a PHP notice because $safecss_post is an array, but the function assumes an object. The solution is to either convert to an object before passing (ew) or to no longer use wp_revisions_to_keep here. I chose the latter option.
2. The "Show more" link appears even if there are no additional revisions to show. That's a bit misleading so it should probably go away when all the revisions (up to max) are listed.

I fixed both of these issues, but it's unclear to me if/how these are related to the above behavior ... especially hard to say since I can't reproduce it.

Anyway patch to follow -- I hope this helps.

[blobaugh]

@jeherve I am also unable to reproduce this. Maybe @mattoperry solved it with the other commit?

[jeherve]

The issue (and the notice) disappeared after applying your patch. Closing this issue. Thank you!

[mattoperry]

No worries -- happy to take more issues -- just let me know.