Comments (6)
I don't think it would be worth adding logic for an actual "fallback" (i.e. "X, or Y only if X is the author") versus just configuring the action with "any-of: X, Y". That would also handle situations like when X is on vacation.
The fix looks ok to me, although I might instead do the check against author
at
If you'd make a PR against the file linked above in this repo, we can get it reviewed and merged.
from jetpack.
from jetpack.
In your fix, you're skipping the required review when the required reviewer is the PR author. On one hand that makes sense. On the other, I wonder if it wouldn't be best to avoid those scenarios altogether by having a fallback reviewer (team or person)?
from jetpack.
@anomiex I had considered that but then the message Requested review(s) from...
would include the name of the skipped author. Also concur that fallback does not feel necessary as there, ideally, should be redundancy in a reviewer list. Though it is interesting that CODEOWNERS just allows any reviewers if the sole owner is also the PR author 🤷
Will open a PR, just wasn't sure if other changes were necessary given the mirror repo setup.
from jetpack.
I had considered that but then the message Requested review(s) from... would include the name of the skipped author.
Good point, I missed that.
from jetpack.
Awesome, thanks for the assist @anomiex 🤝
from jetpack.
Related Issues (20)
- Subscribe block inside text+media block overflows HOT 1
- Newsletter: visual bug on "Form" name input
- Jetpack Search - Superscripted Text Not Found HOT 1
- Tiled Gallery: handle failed uploads gracefully HOT 1
- Customizer CSS not findable/editable after recent Jetpack update HOT 6
- Classic Theme Helper: Warning filemtime(): Assets not being registered properly. HOT 2
- Newsletter: Make it more clear that Newsletter doesn't work with old posts (or allow it to send old posts)
- SSO: Tooltip and tooltip textbox display enhancements for consistency and greater accessibility HOT 1
- Slideshow block: Ensure block can be selected by clicking anywhere within the block (editor) HOT 1
- Boost: Update Cloud CSS UI to include debug steps
- Boost: Css gen library not defined when premium expires HOT 1
- Found Adware inside after installation HOT 1
- PHP Notice during cron related to Sync HOT 5
- Super Cache: rename WPSC_VERSION constant because of conflict
- Subscriptions block: changes menu alignment in navigation menu
- Monorepo tooling: replace classnames with clsx
- Stats: day info popup fails when browser edge is too near HOT 3
- Add deprecation notice displayed on self-hosted sites using the Masterbar module.
- WP 6.6: move from Post Editor to Site Editor versions of Utilities
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jetpack.