Comments (7)
Mapbox markers no longer show up in the editor as of Gutenberg 18.5.0
This was wrong - sorry for the wild goose chase. I misunderstood Gutenberg's release process. Strict Mode was not enabled in 18.5.0, though it is in trunk. I believe it's slated to be part of Gutenberg 18.6.0.
I still think it's Strict Mode that's causing this problem, though I don't know why: it shouldn't have any effect on production builds.
@jeherve, how were you testing the Strict Mode revert? For me:
- Testing on the released 18.5.0 version: I cannot reproduce the bug.
- Testing on trunk: I can reproduce the bug.
- Testing on trunk but applying this patch: I cannot reproduce the bug.
That patch was generated with git revert 736121fac2977be98db294fe51421d96c8526993
and then cleaning up the conflict caused by 9ecf72195f4ce992c3b428407b1b793b1acaf6bc.
from jetpack.
I wasn't able to reproduce it, markers show for me in both Atomic and Simple. Am I missing anything?
Atomic and Simple use a different map provider, Mapkit, instead of the default Mapbox. The problem seems limited to Mapbox for now.
from jetpack.
π REPRODUCTION RESULTS
- Tested on Simple β Could Not Replicate
- Tested on Atomic β Replicated / Could Not Replicate / Uncertain
- Tested onΒ P2Β (optional) β Replicated / Could Not Replicate / Uncertain
- Replicable outside of Dotcom β Yes/No
π FINDINGS/SCREENSHOTS/VIDEO
WordPress.com Simple - markers show correctly on backend and frontend
WordPress.com Atomic
CleanShot.2024-06-17.at.11.43.36.mp4
π ACTIONS
- Triaged
- Requested author feedback
π Message to Author
@mdawaffe I wasn't able to reproduce it, markers show for me in both Atomic and Simple. Am I missing anything?
from jetpack.
I've been unable to replicate this with Jetpack self-hosted either, both locally and using Jurassic Ninja test sites.
I've tested with the current Jetpack stable version, and trunk. I've tested with and without the Gutenberg plugin active at version 18.5.0. I've tested both with a 5yo Mapbox token and a brand new one. Also in Chrome, Firefox and Safari.
@jeherve were you able to replicate?
from jetpack.
I can reproduce with Gutenberg trunk
:
https://cloudup.com/cr9vR5X4F1d
Reverting WordPress/gutenberg#61943 doesn't help me fix it though.
from jetpack.
Very odd. I'll look again today at what's going wrong. Thank you for looking, everyone.
from jetpack.
I have a patch up at #37918
from jetpack.
Related Issues (20)
- Contact Form: move away from onSplit prop
- Boost: Deactivating Boost sometimes breaks WP Super Cache's caching
- Boost: do not cache "Error establishing a database connection" pages HOT 1
- AI Assistant: Change Breve to work with Jetpack AI endpoint
- AI Assistant: Move Breve prompts to backend
- AI Assistant: Test Breve with llama3 endpoint
- AI Assistant: Decide and implement charging strategy for Breve HOT 1
- AI Assistant: Update Breve with current design iteration
- AI Assistant: Add events to Breve
- Jetpack AI Image: change upgrade nudge from warning to error (yellow to red)
- Jetpack AI: add title optimization video to product page
- AI Assistant: Form extension displayed twice
- Blaze eligibility checks under failure conditions
- Jetpack AI Image: show snackbar message when the image gets saved to the library
- Carousel: replaced image in synced image block within pattern is not replaced in Carousel HOT 1
- Google Analytics fails to save tracking code HOT 6
- Enhancement: My Jetpack - VaultPress Card - Explain Icons
- Jetpack AI Image: trigger a new generation when the "return" action happens and there is a prompt on the custom prompt field
- AI Assistant: Extensions are still enabled when Jetpack AI block is hidden
- Block Editor: TypeError: Cannot read properties of undefined (reading 'domReady') HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jetpack.