GithubHelp home page GithubHelp logo

Comments (7)

mdawaffe avatar mdawaffe commented on August 16, 2024 2

Mapbox markers no longer show up in the editor as of Gutenberg 18.5.0

This was wrong - sorry for the wild goose chase. I misunderstood Gutenberg's release process. Strict Mode was not enabled in 18.5.0, though it is in trunk. I believe it's slated to be part of Gutenberg 18.6.0.

I still think it's Strict Mode that's causing this problem, though I don't know why: it shouldn't have any effect on production builds.

@jeherve, how were you testing the Strict Mode revert? For me:

  1. Testing on the released 18.5.0 version: I cannot reproduce the bug.
  2. Testing on trunk: I can reproduce the bug.
  3. Testing on trunk but applying this patch: I cannot reproduce the bug.

That patch was generated with git revert 736121fac2977be98db294fe51421d96c8526993 and then cleaning up the conflict caused by 9ecf72195f4ce992c3b428407b1b793b1acaf6bc.

from jetpack.

jeherve avatar jeherve commented on August 16, 2024 1

I wasn't able to reproduce it, markers show for me in both Atomic and Simple. Am I missing anything?

Atomic and Simple use a different map provider, Mapkit, instead of the default Mapbox. The problem seems limited to Mapbox for now.

from jetpack.

liviopv avatar liviopv commented on August 16, 2024

πŸ“Œ REPRODUCTION RESULTS

  • Tested on Simple – Could Not Replicate
  • Tested on Atomic – Replicated / Could Not Replicate / Uncertain
  • Tested onΒ P2Β (optional) – Replicated / Could Not Replicate / Uncertain
  • Replicable outside of Dotcom – Yes/No

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO
WordPress.com Simple - markers show correctly on backend and frontend
CleanShot 2024-06-17 at 11 34 42@2x

WordPress.com Atomic

CleanShot.2024-06-17.at.11.43.36.mp4

πŸ“Œ ACTIONS

  • Triaged
  • Requested author feedback

πŸ“Œ Message to Author
@mdawaffe I wasn't able to reproduce it, markers show for me in both Atomic and Simple. Am I missing anything?

from jetpack.

coder-karen avatar coder-karen commented on August 16, 2024

I've been unable to replicate this with Jetpack self-hosted either, both locally and using Jurassic Ninja test sites.
I've tested with the current Jetpack stable version, and trunk. I've tested with and without the Gutenberg plugin active at version 18.5.0. I've tested both with a 5yo Mapbox token and a brand new one. Also in Chrome, Firefox and Safari.

@jeherve were you able to replicate?

from jetpack.

jeherve avatar jeherve commented on August 16, 2024

I can reproduce with Gutenberg trunk:

https://cloudup.com/cr9vR5X4F1d

Reverting WordPress/gutenberg#61943 doesn't help me fix it though.

from jetpack.

mdawaffe avatar mdawaffe commented on August 16, 2024

Very odd. I'll look again today at what's going wrong. Thank you for looking, everyone.

from jetpack.

mdawaffe avatar mdawaffe commented on August 16, 2024

I have a patch up at #37918

from jetpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.