Reported unused module but super class is needed about dependency-analysis-gradle-plugin

[emartynov]

Wow, I made ticket so generic, that I can not find the real reference in my project. Let me try to find it first.

[autonomousapps]

Is module B declaring module C as api?

…

On Thu, Feb 6, 2020, 4:48 PM Eugen Martynov ***@***.***> wrote: *Gradle version* 6.0.1 *Android Gradle Plugin (AGP) version* 3.5.3 *Describe the bug* I have module A class AA extends module B class BB. And module B class BB extends module C class CC. The module C is reported as non-used in module A but compilation fails: e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath: class BB, unresolved supertypes: CC *Expected behavior* Module C should not be reported as non-used in module A. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#60>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJG5PLLMIAMPE7ESJJAJJTRBSVXHANCNFSM4KRGQTEQ> .

[autonomousapps]

@emartynov I'm going to close this for now, but feel free to re-open if/when you have more information.

[emartynov]

@autonomousapps I think I found one example.

Clone project https://github.com/chrisbanes/tivi.

Run advices plugin and find next advice:

  {
    "dependency": {
      "identifier": ":presenter-episodedetails"
    },
    "toConfiguration": "implementation"
  },

I found it only one place, in ui-episodedetails module.

I changed it from api to implementation and got:

e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class app.tivi.episodedetails.EpisodeDetailsFragment, unresolved supertypes: app.tivi.episodedetails.EpisodeDetailsViewModel.FactoryProvider

[autonomousapps]

Thanks, I'll take a look.

[autonomousapps]

I believe there is a misunderstanding. I cloned the project and ran ./gradlew buildHealth and looked at advice-pretty.json and see this:

{
  ":app": [
    {
      "dependency": {
        "identifier": ":presenter-episodedetails"
      },
      "toConfiguration": "implementation"
    },
...

what this means is that the app module should add the :presenter-episodedetails project to the implementation configuration. It is NOT saying to remove it from any module's api configuration.

I'm going to close this is as not reproducible, but please feel free to re-open if you find a reproducer.

[nwagu]

@autonomousapps I am running into this too. I made a simple reproducer here https://github.com/nwagu/dagpbrepro. An Android project, with two modules (librarya and libraryb) added. app depends on both librarya and libraryb, and librarya declares a data class that implements an interface declared in libraryb. When I run buildHealth on that project or app:projectHealth, it recommends to remove libraryb depedency from app, which should not be since the superclass (the interface in libraryb) is needed.

[nwagu]

Oh I see buildHealth report also recommends to use api(project(":libraryb")) in librarya. But this is not clear by running app:projectHealth only. I am using this in a large project where for some reason I cannot run buildHealth on the entire project without errors, so I depend on running projectHealth on specific modules