StopProcessingIf about jss-recipes

[grahampugh]

I built in a change to JSSImporter some time ago which negates the need for this (STOP_IF_NO_JSS_UPLOAD), so I'll close this.

[homebysix]

This is an interesting idea, and seems beneficial on first glance. Are there any instances where new_package_request might be False, but we still want to proceed? I'm thinking of recipes that download a flat package directly from the software developer instead of building a package.

[grahampugh]

Yes, that's right. I grabbed the following directly from https://github.com/autopkg/jazzace-recipes/blob/master/Template.ds.recipe and it is just as relevant here:

        <dict>
            <key>Processor</key>
            <string>StopProcessingIf</string>
            <key>Arguments</key>
            <dict>
                <key>predicate</key>
<!-- Depending on the processor in the parent recipe, either download_changed (returned by URLDownloader) 
or new_package_request (returned by PkgCreator and AppPkgCreator) will be used to the left of the ==. -->
                <string>new_package_request == FALSE</string>
            </dict>
        </dict>