Comments (9)
@ldoktor since you wrote this test, could you fix this please?
from autotest-docker.
Yes, it's non-deterministic by default. Anyway you can specify whether to use names in the config (use_names = true/false/RANDOM
, it's described in documentation and config).
from autotest-docker.
btw I never seen this test fail. Could you please provide the log? (I'm using docker-io-0.10.0-2.fc20.x86_64
)
from autotest-docker.
Sometimes you only get one-chance to find a bug, so our tests need to be have predictable behaviour. If using names or id's is an important distinction (for the present), we need to test both. If it's not important right now, then there's no need to have an option. My suggestion is do both, or pick one and hard-code it. Later if it becomes important, it's easy to add, and in the meantime the test is less complex. In either case, the test will remain at least 2x more predictable beyond all the random-crap we can't predict/control. That's why we need this fixed.
from autotest-docker.
That's actually why I really miss cartesian config. It's amazing for these kind of jobs, one test, 2 variants and that's it. (--sig-proxy config would be just 2 config variants (resulting in 8 tests, or 3 variants with 12 tests covering all alternatives)...
I put the randomness here because I take this test as basic usage test, which runs with each build and could uncover basic odd behaviors. When we discover, that naming has problems, we can create specific tests, which would specialize only on the simple reproducer so we won't need to run this time-consuming test twice just because name-translation problem.
Anyway I can implement everything, so just tell me which one you prefer...
from autotest-docker.
Hmmm, eventually we may want to test it both ways, but probably just hard-coding it for "name" now is fine. At this stage, I think we're still all about wide-coverage as opposed to trying to exercise every little nook-and-cranny possible. So just hitting the major points is fine for now.
from autotest-docker.
@ldoktor can we get a PR for this please?
from autotest-docker.
Bumping this to 0.7.5 cause I want to get 0.7.4 done and there's no code for this issue in a PR yet.
from autotest-docker.
This is being addressed in #158
from autotest-docker.
Related Issues (20)
- info test fails
- commit subtest check_commit_default fail HOT 5
- New test: Pull latest also pulls cooresponding tagged image HOT 1
- cp test fails
- Docs: Add sub-section about subtest documentation
- docker_cli/logs/basic test fails w/ unhelpful exception message
- docker_cli/dockerimport/truncated is unreliable
- New test: iptables / firewalld is working. (Docker 1.7.0) HOT 1
- docker_cli/run_volumes cleanup() in base class is not general purpose
- Pre-check wether image exists before container uses it HOT 2
- Improve conf.py's compability for Sphinx v1.3.1 HOT 2
- new test: Exercise --icc=false w/ docker rm --link HOT 1
- Docs: Update development-env. requirements
- Quick Fix: Make image name parsing regex pretty
- Quick Fix: Default omit_empty=True in get_as_list() HOT 1
- Reimplement some dockertest/docker_daemon.py functions HOT 3
- redhat/packaging test fails on Atomic Host HOT 8
- run_cgroups/memory_no_cgroup : fix handling of 0
- Dockercmd module documentation
- Add support for Ubuntu HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autotest-docker.