GithubHelp home page GithubHelp logo

Comments (6)

cevich avatar cevich commented on July 22, 2024

This just needs to be put in place / exercised: baf2d81

from autotest-docker.

Lorquas avatar Lorquas commented on July 22, 2024

Example output of said breaking on a docker ps -a --no-trunc --size:

9afc741721bc7c616329ed2f65128ee21233bb6c10a440519da8b54174b71834   38f7863a18f7        /bin/sh -c '/bin/echo -e '[default]
access_key=$AWS_ACCESS_KEY
secret_key=$AWS_SECRET_KEY' > /.s3cfg'                             2 weeks ago         Exited (0) 2 weeks ago                                                                                                                                                                                                                                                                                                 thirsty_albattani        71 B

This breaks the get_container_list() in dockertest/containers.py when it calls _parse_jiblets()

from autotest-docker.

cevich avatar cevich commented on July 22, 2024

@Lorquas Ohhhh, nice! Yeah, those characters need to be escaped or the table is completely un-parseable. I just reproduced it simply by executing:

docker run b7de3133ff98 bash -c "echo 'line one
line two
line three
' > /tmp/foobar"

There's absolutely no practical way to parse that w/o counting opening/closing tokens. They really should have "COMMAND" as the last column of the table and escape all "special" characters (\n, \e, \r, \g, \b, etc).

from autotest-docker.

cevich avatar cevich commented on July 22, 2024

Interesting this actually works properly:

docker run b7de3133ff98 bash -c "echo 'this is a really really really really super big really really really really long command' > /tmp/foobar"

So the bug has to do with docker scaling column names when the column data includes special characters (newline in this case)

from autotest-docker.

cevich avatar cevich commented on July 22, 2024

Okay, the super-duper long line is now covered by unittests: cevich@fd71017 The bug however, needs to be opened and I'll work on getting the new table-parser worked into images and containers module.

from autotest-docker.

cevich avatar cevich commented on July 22, 2024

Okay, new table parser is now in #88 and bug is open: https://bugzilla.redhat.com/show_bug.cgi?id=1093108

from autotest-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.