Comments (6)
@xmfcx I think pacmod could be moved out easily, but as you say Velodyne is essential to our architecture, so I'm not sure if it should be moved out. The Tamagawa IMU driver doesn't seem to be used much, though. Only two packages depend on it: sample_sensor_kit_launch
and awsim_sensor_kit_launch
from autoware.
@xmfcx I'm sorry for joining late. Explaining the background, these are from TIER IV's reference vehicle/sensor_kit.
I think splitting repos or just removing some is okay, but there are several things to be discussed:
- Which perspective to divide
Do you really want to split drivers? Or do you want to split the entire sensor components? I'm not sure which is better.
Since not every vehicle will use all the drivers, it's better for them to have a separate driver.repos file.
Seeing this purpose, I feel like you want to split the sensor components that aren't related to your vehicle.
This way when people fork autoware, it's easier for them to disable these repositories.
For this, I think users can do it with the current configuration because they are under the sensor_component
section. 🤔
Could you please show me some concrete examples?
- Dependency
We might need to fix some dependencies before splitting them out.
Anyway, I'd like to clarify the background and issues more.
Honestly, I feel that the current proposal might be a bit short-sighted.
So could you share your troubles in more detail with me?
from autoware.
@xmfcx
Could you share more detail about the purpose of this issue?
- Is it to create new repos file to list up Autoware-supported sensor drivers?, or
- Do you just want to remove the need of installing unnecessary drivers?
If latter is the case, I think we can just remove Tamagawa-imu and pacmod-interface drivers since they are not used in tutorials anyways.
from autoware.
@xmfcx I agree with you, the drivers are quite specific to the vehicle where Autoware is running, so it'd be better to move them to a separate .repos
file and let users use whatever driver they need for their vehicle.
from autoware.
@kenji-miyake @mitsudome-r @esteve maybe we can also discuss about whether we should build these packages as part of the CI or not.
Or discuss whether we should do the proposal on this issue at all.
From these 3, I think velodyne is the more essential one but I'm not sure about what to do with the others. Any thought is appreciated.
from autoware.
So, I have thought about this more generally and here are the things I'd like to achieve:
- Users shouldn't be forced to build drivers that they won't use.
- The drivers should be tested in the repository through the CI to keep compatible.
- Some drivers are essential, like the nebula driver.
For this, I will separate out the following:
pacmod_interface
tamagawa_imu_driver
into a different .repos
file called extra-packages.repos
.
Will modify the CI to pull them along with the others, build and test as usual.
The users will download the usual autoware.repos
without these packages.
If they want to, they can download it with the extra-packages.repos
.
In the future, we can think of similar non-essential external packages to this list.
Do you think this is reasonable? @esteve @mitsudome-r ?
from autoware.
Related Issues (20)
- Test highway localization feasibility of Current Autoware Pipe-Line HOT 34
- Implementing lane detection method for lane level localization purposes HOT 2
- Collect Urban Dataset for Autoware and Autoware Labs HOT 25
- Report results of the weekly scenario tests publicly as dashboard
- Autoware weekly scenario tests are failing. HOT 2
- Docker Image OpenADK with CUDA support has an issue with CUDA installation HOT 2
- Prune and document the docker packages HOT 3
- Migration from autoware_auto_msgs to autoware_msgs
- Enhancing scenario_simulator_v2 to print or visualize parameters/modifiers used for test iterations
- When the display scale is set to 200% the Rviz window always crashes HOT 1
- `docker-build-and-push` should not push an image for every commit to main
- `docker-build-and-push-main` is failing HOT 4
- compare_map_segmentation
- Missing environment variables in devel Docker container
- Separation of `autoware_common` to `autoware_cmake`, `autoware_utils` and `autoware_lanelet2_extension` HOT 2
- `docker/build.sh` fails with `ssh_auth_sock: no such file or directory` HOT 1
- Only `cuda` jobs generate empty cache on `build-main` and `build-main-self-hosted` workflows
- Autoware packages release from ROS buildfarm
- Add lightweight docker build option HOT 2
- CMake error during installation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autoware.