Versions in install_if_not_exists about hypersdk

[containerman17]

Or even replace with go run, then no binary installation needed.

[iFrostizz]

Possible leftover from #1443
Wondering if it could be related to this tag not being picked up >

hypersdk/examples/morpheusvm/scripts/lint.sh

Line 15 in 69e96fc

export GOLANGCI_LINT_VERSION="v1.51.2"

[containerman17]

I cleaned up the system and started from a fresh .devcontainer/default-go-env/devcontainer.json. Below are the logs:

• HyperSDK Lint Log: HyperSDK Lint Log
• MorpheusVM Lint Log: MorpheusVM Lint Log

TLDR: the same

[containerman17]

vscode ➜ /workspaces/hypersdk/examples/morpheusvm (main) $ golangci-lint --version
golangci-lint has version 1.60.1 built with go1.23.0 from 3298c104 on 2024-08-14T01:15:05Z

Yes, you are right about the version

[containerman17]

The issue is that install_if_not_exists doesn't check the version, and Microsoft ships golangci-lint v1.60.1 by default.

@iFrostizz, do you plan to upgrade the version in the next month or two? If not, I can add a post-install script to remove golangci-lint, or modify install_if_not_exists to check the version.

[containerman17]

We could simplify by replacing install_if_not_exists with go install every time. Running go install on an already installed package takes just 0.7 to 1 second, but it ensures the correct version is always installed.

[iFrostizz]

Good point, in this case if only 2 lints are left then maybe that could be best to replace install_if_not_exists by a hand-written installation of the specific version after having bumped the version ? It doesn't really seem a good idea to use different versions of the same binary across scripts

[aaronbuchwald]

The same is true for all of the places where we are using install_if_not_exists no?

[containerman17]

Yes, but everything else is working well so far. I’d prefer to keep the changes minimal here.