GithubHelp home page GithubHelp logo

Comments (7)

c-morten avatar c-morten commented on June 30, 2024 2

^ Thanks @jkeys-ecg-nmsu, this is really helpful info. I'll take a look at Babylon's latest preview build later this evening and see what has changed in the audio system.

from amazon-sumerian-hosts.

jkeys-ecg-nmsu avatar jkeys-ecg-nmsu commented on June 30, 2024 1

Also, this bug was replicated on 1.3.2 of this repo, and [email protected].

When I downgraded to [email protected], the error went away.

from amazon-sumerian-hosts.

jkeys-ecg-nmsu avatar jkeys-ecg-nmsu commented on June 30, 2024

@c-morten I can provide the actual logs over email if they would help.

Stack trace:
image

Specifically, it errors on this line in Speech.js:

image

from amazon-sumerian-hosts.

KISSMonX avatar KISSMonX commented on June 30, 2024

Also, this bug was replicated on 1.3.2 of this repo, and [email protected].

When I downgraded to [email protected], the error went away.

This works! thank you very much.
Look forward to further updates.

from amazon-sumerian-hosts.

KISSMonX avatar KISSMonX commented on June 30, 2024

^ Thanks @jkeys-ecg-nmsu, this is really helpful info. I'll take a look at Babylon's latest preview build later this evening and see what has changed in the audio system.

Looks like BabylonJS preview version has compatibility issues with Sumerian. Hope the new preview version of BabylonJS will fix this.

from amazon-sumerian-hosts.

DC2009 avatar DC2009 commented on June 30, 2024

I temporary solved the problem by bypassing the library Speech stop.
I think it's enough to update the babylon function by removing the line highlighted in #30 (comment)

import HOST from "amazon-sumerian-hosts/dist/host.babylon";

/**
 * @extends babylon/Speech
 */
class Speech extends HOST.aws.Speech {
  /**
   * @constructor
   *
   * @param {Babylon.js/TextToSpeechFeature} speaker - The owner of the Speech
   * that will emit speechmark messages.
   * @param {string} text - The text of the speech.
   * @param {Array.<Object>} [speechmarks=[]] - An array of speechmark objects representing
   * the text and timing of the speech.
   * @param {Object} audioConfig - Object containing audio and url.
   * @param {external:Audio} audioConfig.audio - Playable audio object.
   */

  stop() {
    this._audio.stop();
    this._pauseAudio();

    if (this._promise) {
      this._promise.resolve();
      this._promise = null;
    }

    this._playing = false;
  }
}

export default Speech;

from amazon-sumerian-hosts.

c-morten avatar c-morten commented on June 30, 2024

Fixed in v1.3.3

from amazon-sumerian-hosts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.