Mismatched control sync about aws-security-hub-cross-account-controls-disabler

[4ndr4s]

Were you able to figure out ?

[learningpool-jonathan]

This happens when there are controls on the member account that are not in the admin account and it ends up messing up the syncing.

I added some code to check the control id's match.

`if admin_key == member_key:
                # Same security standard

                # Create dictionaries to map ControlId to control objects for admin and member controls
                admin_controls_dict = {control["ControlId"]: control for control in admin_controls[admin_key]}
                member_controls_dict = {control["ControlId"]: control for control in member_controls[member_key]}

                for admin_control_id, admin_control in admin_controls_dict.items():
                    # Check if the admin control exists in the member controls
                    if admin_control_id in member_controls_dict:
                        member_control = member_controls_dict[admin_control_id]`

[4ndr4s]

@learningpool-jonathan how it comes that controls are not the same across different accounts? if you are enabling the same standards controls should be the same across the org, at least per region, there are some controls that are for global resources, for this case I added some logic to evaluate if the control is available in that region. besides being able to enable/disable global controls. as described here