Issues with v_generate_tbl_ddl.sql about amazon-redshift-utils

[zach-data]

The first issue is caused by an issue with how SQL comments are handled within querytext by the Redshift JDBC 1.1.13 driver. You can mitigate this behavior with the 1.1.10 version of the Redshift driver until we release the next version.

The ORDER BY clauses are to ensure a consistent positioning of columns, but testing against the pg_catalog tables shows this consistent ordering is enforced already. These are likely to be redundant - will test and remove if confirmed to be the case.

[jrandrews]

Thank you, reverting from the Redshift JDBC 1.1.13 driver to the 1.1.10 driver worked.

I'm curious -- I can't see any references now to the 1.1.13 driver anywhere but I know I must have downloaded it from somewhere before. Was the 1.1.13 driver formerly available on Amazon's site and then removed due to some issues found with the driver?

[zach-data]

We had previously identified the issue you raised here and removed the driver while we work on a fix.

[zach-data]

Is there a reason to have the ORDER BY clauses in the subqueries? ... I think there are some extra parentheses?

We globally sort by seq which is properly generated by incrementing attnum or abs(a.attsortkeyord) to maintain column order, so there is no meaningful value in these redundant ORDER BY clauses in the various subqueries. Benchmarks against a version of the VIEW where these are omitted resulted in a non-measurable performance change. I will remove these as well as the redundant parenthesis.

[jrandrews]

Thanks, chrisz. I really appreciate the prompt feedback.