Singleton services are not disposed when IIS server is stopped. about extensions-dependency-injection

[g7ed6e]

Indeed i just checked and ServiceProvider is internal in 1.1.1.
I also checked Microsoft.Extensions.DependencyInjection 2.1.1 (net461, netstandard2.0), ServiceProvider is public in this version, thus the disposal of the ServiceProvider can be trigger by user code.

I'm closing this issue as ServiceProvider lifetime management is not handled by this package.

[g7ed6e]

Both MVC and WebApi packages externalize the IServiceProvider lifetime management to the user as the IServiceProvider instance is injected by constructor. I checked the MVC/WebApi sample and noticed that the IServiceProvider instance is not disposed, thus singleton are not disposed too.
You should indeed be able to get singleton instances disposed by adding the below code in Global.asax.cs file.

public void Application_End()
{
    ServiceProviderConfig.ServiceProvider?.Dispose();
}

Could you please open a pull request to fix the sample ?

[jun1sfukui]

ServiceProviderConfig.ServiceProvider?.Dispose() doesn't work because IServiceProvider doesn't have Dispose().

Would it be better to change the type of ServiceProviderConfig.ServiceProvider to ServiceProvider?

Any solutions?

[g7ed6e]

As you suggested you could change the type of the property in the sample to be able to call Dispose method of the user provided instance of IServiceProvider.

[jun1sfukui]

Actually I have tried it but it didn't work because the ServiceProvider class didn't exist.

I think it because of the .NET Framework version of the sample projects are 4.5.2 and the using package version of Microsoft.Extensions.DependencyInjection is very old.

I'm sorry I don't have enough time to update all projects to the latest version and try it out.

[g7ed6e]

You need to install Microsoft.Extensions.DependencyInjection to get acces to the ServiceProvider type.

[jun1sfukui]

Already installed it but the version is 1.1.1 because the packages.config of WebApi.Sample project references the very old version.
Microsoft.Extensions.DependencyInjection of version 1.1.1 seems to not publish the ServiceProvider class.