[PATCH] Add line numbers to source code about google-code-prettify

[GoogleCodeExporter]

Maybe it's a good idea to create something like this using a list. This would 
allow
us to still copy paste the code easily (without selecting line numbers) and 
would
give the possibility to add row colors and/or row highlighting.

Original comment by [email protected] on 25 Apr 2008 at 11:11

[GoogleCodeExporter]

For anyone who's interested, here's a new patch based on Martin Probst's work on
displaying line numbers, with a few improvements:

- improve cross-browser support.
  (tested on IE6, IE7, Opera9.51, Konqueror3.5.9, Firefox3)
- use <table> to arrange linebox and prettified box, so that the layout 
  will still work for browsers with CSS turned off but Javascript turned on.
- support table layout <pre><table>..</table</pre> used in Google Code Hosting.

I also attach a test file containing test cases for line numbers rendering.

Original comment by teohuiming on 9 Jul 2008 at 4:34

Attachments:

• r47-prettify.js.diff
• r47-prettify.css.diff
• linebox_test.html

[GoogleCodeExporter]

Rather than try and implement all kinds of decorations, I thought I'd allow 
people to
embed their own.

I implemented a scheme to allow this.  See "nocode" spans as described at
http://google-code-prettify.googlecode.com/svn/trunk/README.html

I'm going to mark this fixed, but please reopen if this doesn't meet your need.

Original comment by [email protected] on 14 Jul 2008 at 11:00

• Changed state: Fixed

[GoogleCodeExporter]

Sorry that I didn't respond earlier, but apparently I was not notified of 
changes in this bug. I also cannot see 
how to re-open it (?!). However I'd vote to re-open this, as the proposed 
solution doesn't really work for 
me.

I think the idea of this library is to add decorations to code on the fly using 
JavaScript. Now I consider line 
numbers decorations that don't really belong with the code, so I'd like my 
JavaScript to add them 
automatically, without me having to manually enter them in the code (and in 
quite a verbose syntax using 
<span/>).

Also, the original patch and the enhancement by teohuiming allow users to 
copy/paste the code from the 
snippet without the line numbers (as it is within a different box element), 
which is IMHO an important 
feature not supported by the <span/> method.

Original comment by [email protected] on 14 Sep 2008 at 8:57

[GoogleCodeExporter]

For reference, you can reopen a bug by changing the "Status" from "Fixed" to 
"New".

Original comment by [email protected] on 22 Sep 2008 at 9:42

• Changed state: New

[GoogleCodeExporter]

i agree with Martin - the original proposed implementation, or the changes by 
Teo,
would be very interesting features.

Original comment by [email protected] on 21 Feb 2009 at 11:44

[GoogleCodeExporter]

Try using the <code> tag instead of the <div> tag to make it much more semantic

Original comment by [email protected] on 10 Jul 2009 at 3:17

[GoogleCodeExporter]

An HTML ordered list sounds semantically sound (as the meta line numbers are 
better
coupled closer to the content) and far less complicated:

<code>
    <ol>
        <li>...</li>
        ...
    </ol>
</code>

In a copy/paste operation, browsers often don't copy the item/line numbers
automatically generated. Workarounds for browsers that do may be required.

Original comment by [email protected] on 10 Mar 2010 at 10:35

[GoogleCodeExporter]

So there should be a way to get the rewriter to put <li></li> around each line?
If those are in the code already, the system should preserve them.

Original comment by [email protected] on 11 Mar 2010 at 4:50

[GoogleCodeExporter]

The drawback with <ol><li>...</li></ol> is that you cannot easily create a 
stepping (only display a number 
every n lines), can you? The advantage is of course that it is much easier to 
do the counting and aligning the 
lines correctly.

Original comment by [email protected] on 11 Mar 2010 at 8:20

[GoogleCodeExporter]

Can you explain steppings further? I'm not sure what they are.

I think I straight correlation between the line numbers a compiler/lint/etc 
sees and
what we see is paramount in easing the administrative burden of finding/fixing 
bugs.

Original comment by [email protected] on 11 Mar 2010 at 2:27

[GoogleCodeExporter]

With stepping I mean the common practice that you only want every Nth line 
number to be displayed.

E.g.
1. for (x in xs) {
      print('a')
      print('a')
      print('a')
5.   print('a')
      print('a')
      print('a')
      print('a')
10. print('a')
    }

Original comment by [email protected] on 11 Mar 2010 at 6:21

[GoogleCodeExporter]

Can you do stepping in CSS?
  <ol>
    <li class="step0">
    <li class="step1">
    <li class="step2">
    <li class="step3">
    <li class="step4">
    <li class="step5">
    ...
  </ol>
  <style>
    li.step1, ... li.step4 { list-style-type: none }
  </style>

Original comment by [email protected] on 11 Mar 2010 at 6:39

[GoogleCodeExporter]

Yes

li { list-style-type: none; }

li:first-child, /* 1 */
li:nth-child(5n) { list-style-type: decimal; } /* 5, 10, 15... */

Original comment by [email protected] on 11 Mar 2010 at 9:22

[GoogleCodeExporter]

That's much nicer CSS, though it might stomp on list-styles outside 
.prettyprint blocks.

Maybe prefix those selectors with
   .prettyprint > 

I'm unfamiliar with the nth-child pseudo-selector.  Does it work on most 
browsers?

Original comment by [email protected] on 11 Mar 2010 at 10:00

[GoogleCodeExporter]

It was intended as informative not normative.
:)

Looking at the source (prettify.css), pre.prettyprint appears to be the relevant
wrapper class.

nth-child falls under CSS3 selectors (currently at PR Proposed Recommendation
status). Support is better than you'd think: most current browsers. The 
elephant in
the room can be Dean-handled: http://ie7-js.googlecode.com/svn/test/index.html

Original comment by [email protected] on 11 Mar 2010 at 10:39

[GoogleCodeExporter]

So I guess the open questions are:

Does prettyprint need to insert tags to separate or delimit line boundaries?
Or just recommend that users delimit their line boundaries with <li> or some 
other
block level tags?

Does prettyprint need to descend into <ol class=prettyprint>?
Or just recommend <li> tags inside <code class=prettyprint>?

Should prettyprint.js include any CSS related to line numbering?

What documentation/FAQs need to be updated?

Original comment by [email protected] on 12 Mar 2010 at 1:08

[GoogleCodeExporter]

I would suggest that prettyprint adds the <ol> and <li> automatically, the 
whole promise of the library is that 
you throw a bunch of plain text within a <pre> tag at it and it will do it's 
thing. Requiring people to add <li>s 
would work against that.

Thus, there should also be CSS included.

Original comment by [email protected] on 12 Mar 2010 at 8:37

[GoogleCodeExporter]

You really need to take seriously what the user above said:
        "the whole promise of the library is that 
you throw a bunch of plain text within a <pre> tag at it and it will do it's 
thing."

Original comment by [email protected] on 22 Mar 2010 at 2:19

[GoogleCodeExporter]

Agreed in principle, but I need to check what browsers do with <ol> and <li> 
within
<pre> tags.

Original comment by [email protected] on 23 Mar 2010 at 6:30

[GoogleCodeExporter]

IMO an easier solution would be to use two TD columns, with the numbers on the 
left 
and code on the right. This also simplifies copy/paste operations, since you 
can 
select a single TD's contents without also selecting the numbers. Word-wrapping 
might 
be problematic with this approach, however, unless each line is a TR (in which 
case 
the copy/paste benefit goes away again, i think).

Original comment by [email protected] on 23 Mar 2010 at 6:45

[GoogleCodeExporter]

sgbeal,

Thanks for the suggestion.  How does copy work around tables when the selection
starts before the table.

Original comment by [email protected] on 23 Mar 2010 at 7:02

[GoogleCodeExporter]

I updated the patch by teohuiming
(http://code.google.com/p/google-code-prettify/issues/detail?id=22#c2) to be 
based on
prettify-3-Dec-2009.zip, fixed some issues I had with it and added a way to 
specify
the starting line number.

Patch set attached. (only for prettify.js; I did some CSS changes too but I 
don't
think any were necessary to make it work. Do use the css patch by teohuiming!)

Original comment by [email protected] on 4 May 2010 at 8:20

Attachments:

• 0001-applied-patch-r47-prettify.js.diff-and-r47-prettify..patch
• 0002-fix-use-of-undefined-variable-isIE6.patch
• 0003-fix-Error-firstChild.tagName-is-undefined.patch
• 0004-fix-createLineBox-being-called-too-many-times.patch
• 0005-first-line-number-can-be-set-using-linenostart-XX-CS.patch
• 0006-prettify-read-PR_CREATE_LINE_BOX-from-window-element.patch

[GoogleCodeExporter]

I would love to see line numbers included.

tobivollebregt would you be able to repost attaching your patched prettify.js 
and the prettify.css patched by 
teohuiming?... 

bonus points for attaching minified versions also ;-)

Original comment by [email protected] on 25 May 2010 at 6:57

[GoogleCodeExporter]

Sorry I've been so quiet lately.
I'm going to try to get some free time soonish to work through a backlog of 
bugs.
If this bug is a major issue for you, please respond on 
http://groups.google.com/group/js-
code-prettifier where I'm going to ask people what their priorities are as far 
as bug fixes.

Original comment by [email protected] on 27 May 2010 at 2:40

[GoogleCodeExporter]

Candidate implementation up and discussion at 
http://groups.google.com/group/js-code-prettifier/browse_thread/thread/fea5f0528
345f3d1

Original comment by [email protected] on 19 Jul 2010 at 6:16

• Changed state: Started

[GoogleCodeExporter]

The candidate implementation is now stable.

Original comment by [email protected] on 5 Apr 2011 at 2:54

• Changed state: Fixed