GithubHelp home page GithubHelp logo

Comments (8)

rchinthakuntla avatar rchinthakuntla commented on June 29, 2024 1

Chris,

I got a better idea on how to handle invalid organizations. For sure, we wan to throw error. As part of error message, can we show what the valid organizations are (both development and consumer)? Remember the startInstance script we provide in API Gateway? When I try to run it with invalid group or instance name, it errors out but provides information with the valid options. We can follow the same model here. This way, the team owing this CLI tool can correct the script and rerun it (instead of signing into Web UI and see what the valid organizations are).

Makes sense?

Thanks
Ravee

from apimanager-swagger-promote.

rekies avatar rekies commented on June 29, 2024 1

I really like the idea of failing and getting back the options as a result. It's a real time saver and production boost for CLI.

RenΓ©

from apimanager-swagger-promote.

cwiechmann avatar cwiechmann commented on June 29, 2024

Some questions to the team (@rchinthakuntla, @rathnapandi, @rekies):

  • What should happen, if a defined Org doesn't exists?
    • Should it:
      • Just skip this org? (I do prefer this one with a dedicated return code)
      • Fail completely?
      • Should there be an option, that the Org will be created "On-Demand"?
  • I plan to add an Option: "ALL" (instead of the org-name), to assign permissions to all orgs. Agree?
  • Adding an option for the tool to ignore Client-Organizations definitions
    • might be useful to avoid, that an API-Developer can control directly who can consume his API.
  • should the config be named: organizations, clientOrganizations or clientOrgs?

Any other thoughts on this?

Chris

from apimanager-swagger-promote.

rathnapandi avatar rathnapandi commented on June 29, 2024

Default behavior should be fail completely. If user uses force flag, ignore the organization which does not exist on target APIM.

from apimanager-swagger-promote.

rchinthakuntla avatar rchinthakuntla commented on June 29, 2024

I agree with Rathna's comments. Creating Org on-demand might not be desired because Developers often might not know which consumer organizations tend to consume the APIs they own. Failing is a better and should be the only option in my opinion because it gives the customer an opportunity to introspect and make the right fixes. Force flag should be added, only if asked by customers. End goal is to make sure the API configurations are accurate and do not have any elements like invalid organizations.

Thanks
Ravee

from apimanager-swagger-promote.

cwiechmann avatar cwiechmann commented on June 29, 2024

Yes, makes sense and I have updated the description how I plan to implement it.

from apimanager-swagger-promote.

cwiechmann avatar cwiechmann commented on June 29, 2024

Merge support for Organizations control into develop branch. Will be part of the next release.

from apimanager-swagger-promote.

cwiechmann avatar cwiechmann commented on June 29, 2024

Just released version 1.3 which supports management of Client-Organizations.

from apimanager-swagger-promote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.