GithubHelp home page GithubHelp logo

Comments (5)

cwiechmann avatar cwiechmann commented on June 29, 2024

Yes, that's expected behavior as the parameter: backendBasePath controls the API-Manager Proxy-Configuration and is not changing the Swagger-File itself.
And as the backendBasePath is configured on the FE-API, it has no impact on the Backend-URL.

Does it makes sense?

from apimanager-swagger-promote.

vuvdoan avatar vuvdoan commented on June 29, 2024

that's the answer I was afraid of :) Thanks for clarification.
Is there a way to parameterize (actually replace the host param in the swagger file) with this tool?

from apimanager-swagger-promote.

cwiechmann avatar cwiechmann commented on June 29, 2024

Not at the moment. Perhaps something which can be added later. Should be an easy thing to do, as the Swagger-File is loaded internally anyway.

from apimanager-swagger-promote.

cwiechmann avatar cwiechmann commented on June 29, 2024

@vuvdoan, As the enhancement makes so much sense, I decided to implement this feature for the next release, which is now done.
I have even decided to perform this by default (only for JSON Based Swagger-Files). For anybody who don't want this, it can be turned off using the "hidden" parameter: "replaceHostInSwagger" set to false.

See env.properties.sample for reference in the next release. Can also be used as a normal CLI parameter.

However, the code is implemented in way, if the replace fails for any reason, it is logged with an error message + exception trace, but the tool continues.
Also please note, as the backendBasePath is now changing the Swagger-File (APIDefinition) the tool will consider it as a changed property. And as a changed API-Definition leads to a Re-Creation of the API, from now on changing the backendBasePath, will re-create the API. In the same way, as it happens when doing any other change in the Swagger-File. Hope this okay?

from apimanager-swagger-promote.

cwiechmann avatar cwiechmann commented on June 29, 2024

Released with version 1.5.3

from apimanager-swagger-promote.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.