Support version '2017-03-01-preview' for Microsoft.Sql/servers/securityAlertPolicies about devopskit

[VincentLepape]

I have exactly the same problem.
Let me know when the issue will be fixed

The 2 rules below for the "securityAlertPolicies" seems not compatible with any API versions

"jsonPath": [ "$.properties.emailAccountAdmins" ], "matchType": "Boolean", "data": { "value": true }
+
"jsonPath": [ "$.properties.emailAddresses" ], "matchType": "StringWhitespace",

See my pull request :
#764

"jsonPath": [ "$.properties.emailAccountAdmins" ], "matchType": "Boolean", "data": { "value": true }

replaced by

"jsonPath": [ "$.properties.emailAddresses" ], "matchType": "ItemCount", "data": { "type": "GreaterThanOrEqual", "value": 1 }

[mikanyg]

I see some very weird behaviour for this control in ARM template check. Even when using the compliant ARM template for SQL Server, the ARM Template check fails due to expecting a boolean value for the emailAccountAdmins property. But the ARM Template showcases a string property with value 'Enabled', and doing an ARM deployment validation fails if this property is a boolean whenever the api version is 2015-05-01-preview.

Browsing the official docs I cannot find support for 2015: https://docs.microsoft.com/en-us/azure/templates/microsoft.sql/2015-05-01-preview/servers/securityalertpolicies
only 2017 api version seems official: https://docs.microsoft.com/en-us/azure/templates/microsoft.sql/2017-03-01-preview/servers/securityalertpolicies

[mikanyg]

@VincentLepape did you also experience the same issue for the disabledAlerts property? I can see that the matchType is the same as for emailAddresses but the official ARM template has it as a string array.

[mikanyg]

Another thing to note is that even though the failed results is being added to an exclusion file and the failures are correctly set to Skipped, the overall task is still failing. My guess is that its due to some internal exception during evalution of Microsoft.Sql/servers/securityAlertPolicies resources.

When I remove all Microsoft.Sql/servers/* resources from the template, but still have other resources with some failures added to exclusion file, the overall task succeeds as expected.

[mikanyg]

This seems to have been resolved in the latest AzSK 4.6.0 release. At least we are no longer getting failures from Microsoft.Sql/servers/*.