TS2322: Type 'string | undefined' is not assignable to type 'string' about ms-identity-javascript-v2

[derisen]

This looks more to do with TypeScript than with MSAL. And I would say there's nothing wrong here. In case auth.getAccount() fails for some reason, your account variable will be set to null, so oid will be null too. So you are asserting that it will not be null with the (!) mark. (but yeah oid will be always be a string as long as getAccount() succeeds)

You could of course ask why should getAccount() return null when fails and not something else on msal.js repo.

[DarkLite1]

I've looked a bit further into this. When you look at Account.ts you see the following lines:

import { StringDict } from "./MsalTypes";
idTokenClaims: StringDict;

When verifying MsalTypes we see this:

export type StringDict = {[key: string]: string};

The issue with this setup is that the property oid on the object idTokenClaims can be undefined when it's not added. I think this is why TS fails to see that there is always an oid property when getAccount() succeeds.

If I got this wrong please correct me. As I see it now there are 3 options:

• Either TS should be smart enough to see that the property oid is always there when getAccount() succeeds, this is not the case, so there should be a bug report at TS for this issue.
• TS is correct but the type definition in the msal library is incorrect and should be corrected. So that the property oid is hard coded on the idTokenClaims property.
• I got it totally wrong, which happens :D

[derisen]

Hmm, I would think that the option 2 is more likely. Could you raise this issue in msal.js repo? Not quite sure what was the expectation from server with idTokenClaims.

[DarkLite1]

Closing this one for the new issue created.