GithubHelp home page GithubHelp logo

Comments (6)

rohitnarula7176 avatar rohitnarula7176 commented on June 14, 2024 1

@spottedmahn We would be open to a community PR.

from microsoft-authentication-library-for-js.

spottedmahn avatar spottedmahn commented on June 14, 2024

Would you take a community PR?

from microsoft-authentication-library-for-js.

sameerag avatar sameerag commented on June 14, 2024

@spottedmahn We have enhanced our error handling with our API changes and this would help catch any authority validation or endpoint errors.

Please download our latest preview package or pull the dev branch and try updating your code and see if the issue still persists.

If you would like guidance on how to use the new version of the library, please review our wiki page here.

from microsoft-authentication-library-for-js.

spottedmahn avatar spottedmahn commented on June 14, 2024

Hi @sameerag - that's great. Can you provide a link to the PR/commit?

from microsoft-authentication-library-for-js.

sameerag avatar sameerag commented on June 14, 2024

So we had multiple PRs as this was a big API surface change activity. npm@msal-preview should pull the latest code for you as mentioned above - or 'dev' branch is up to date. We are planning a release soon and get out of the preview mode. This release is majorly focused in API surface changes to improve the usability of the library.

Having said that, some of the inner workings updates (includes logging) will follow once we stabilize the API changes for the community.

Regarding logging/error handling some things of note:

  • Validating Authority has error handling code now. This part of the code is going through some feature changes to accommodate a more generic solution, hence the release after the current release (in plan) will have more traction.
  • we added some error checking for endPointResolution but this is not complete. Some code could be simplified and there is an internal tracker for this.
  • Logging is separate from API Changes as we want to evolve logging into a more consistent pattern across the code. This is a separate effort which we plan in a future release.

from microsoft-authentication-library-for-js.

spottedmahn avatar spottedmahn commented on June 14, 2024

So we had multiple PRs as this was a big API surface change activity

Fair enough, thanks for the reply 👍

from microsoft-authentication-library-for-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.