Comments (6)
@spottedmahn We would be open to a community PR.
from microsoft-authentication-library-for-js.
Would you take a community PR?
from microsoft-authentication-library-for-js.
@spottedmahn We have enhanced our error handling with our API changes and this would help catch any authority validation or endpoint errors.
Please download our latest preview package or pull the dev branch and try updating your code and see if the issue still persists.
If you would like guidance on how to use the new version of the library, please review our wiki page here.
from microsoft-authentication-library-for-js.
Hi @sameerag - that's great. Can you provide a link to the PR/commit?
from microsoft-authentication-library-for-js.
So we had multiple PRs as this was a big API surface change activity. npm@msal-preview should pull the latest code for you as mentioned above - or 'dev' branch is up to date. We are planning a release soon and get out of the preview mode. This release is majorly focused in API surface changes to improve the usability of the library.
Having said that, some of the inner workings updates (includes logging) will follow once we stabilize the API changes for the community.
Regarding logging/error handling some things of note:
- Validating Authority has error handling code now. This part of the code is going through some feature changes to accommodate a more generic solution, hence the release after the current release (in plan) will have more traction.
- we added some error checking for endPointResolution but this is not complete. Some code could be simplified and there is an internal tracker for this.
- Logging is separate from API Changes as we want to evolve logging into a more consistent pattern across the code. This is a separate effort which we plan in a future release.
from microsoft-authentication-library-for-js.
So we had multiple PRs as this was a big API surface change activity
Fair enough, thanks for the reply 👍
from microsoft-authentication-library-for-js.
Related Issues (20)
- [msal-node] Confidential Client - Client Assertion implementation should accept callback instead of string argument HOT 3
- MSAL Angular Application Redirect URL Marked as Dangerous Site After Microsoft Login HOT 3
- SSO, 400 (Bad Request), POST https://login.microsoftonline.com/MS_TENANT_ID/oauth2/v2.0/token HOT 1
- msal-node "No 'Access-Co ntrol-Allow-Origin' header is present on the requested resource." error when redirecting to URL returned by getAuthCodeUrl() HOT 1
- The handleRedirectPromise not executing on fulfillment HOT 3
- Unexpected behavior when custom auth is enabled for Azure Static Web App HOT 1
- Cannot use aplication after deployment for some clients after upgrading from version 2 to 3 (and Angular to version 17)
- acquireTokenSilent with MSAL.js giving error HOT 2
- msal v3 - navigateToLoginRequestUrl true does not wait for logic performed in redirectUri component before navigating to previous page HOT 2
- Looking for reference for MSAL.JS HOT 1
- Update official CCA samples to Node v2
- BrowserAuthError: interaction_in_progress: Interaction is currently in progress HOT 1
- Can't bypass the selection of user even adding the logoutRedirect method HOT 1
- Support multiple clientId dynamically with MSAL V3 HOT 7
- Library emits uncaught exception if AcquireTokenSilent fails
- Endpoints cannot be resolved after enabling custom domains HOT 1
- Avoid applying .toLowerCase() to the authority URL HOT 1
- Unable to use the same Instance of PublicClientApplication as Prop for MsalProvider and in Loader of a React Router Route HOT 4
- ServerError msal-browser outlook add-in on Android HOT 3
- Creating NativeBrokerPlugin requires process.exit() to shutdown node HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from microsoft-authentication-library-for-js.