Comments (12)
That's not good! We should probably check for a fully qualified name.
from neil.
I can't repro the "deps.edn becomes empty" part:
borkdude@m1 /tmp/dude $ neil dep add com.rpl/specter
borkdude@m1 /tmp/dude $ cat deps.edn
{:deps {com.rpl/specter {:mvn/version "1.1.4"}}
:aliases {}}
borkdude@m1 /tmp/dude $ neil dep add com.rpl.specter
borkdude@m1 /tmp/dude $ cat deps.edn
{:deps {com.rpl/specter {:mvn/version "1.1.4"}
com.rpl.specter {:mvn/version nil}}
:aliases {}}
Can you provide a sequence like the above?
We should probably never add a dep when the version is nil
.
from neil.
Here is my justfile
:
akond@akond:~/workspace-test/xxxx$ cat justfile
DIR:="issue-131"
run:
rm -rf {{DIR}}
neil new --name {{DIR}}
hd {{DIR}}/deps.edn
cd {{DIR}}; neil add dep com.rpl.specter
hd {{DIR}}/deps.edn
So the result looks :
akond@akond:~/workspace-test/xxxx$ just
rm -rf issue-131
neil new --name issue-131
Creating project from org.corfield.new/scratch in issue-131
hd issue-131/deps.edn
00000000 7b 3a 70 61 74 68 73 20 5b 22 73 72 63 22 5d 0a |{:paths ["src"].|
00000010 20 3a 64 65 70 73 20 20 7b 7d 0a 20 3a 61 6c 69 | :deps {}. :ali|
00000020 61 73 65 73 20 0a 20 7b 3a 6e 65 69 6c 20 7b 3a |ases . {:neil {:|
00000030 70 72 6f 6a 65 63 74 20 7b 3a 6e 61 6d 65 20 69 |project {:name i|
00000040 73 73 75 65 2d 31 33 31 2f 69 73 73 75 65 2d 31 |ssue-131/issue-1|
00000050 33 31 7d 7d 7d 7d 0a |31}}}}.|
00000057
cd issue-131; neil add dep com.rpl.specter
hd issue-131/deps.edn
00000000 0a |.|
00000001
Please, notice, that I use com.rpl.specter
and not com.rpl/specter
from neil.
Yes, you should use the fully qualified symbol, but we should have some error checking for this.
from neil.
Also please specify the version of neil you are using.
from neil.
akond@akond:~/workspace-test/xxxx$ neil --version
neil 0.1.46
from neil.
Yes, the repo name is bogus, but I don't think that emptying deps.edn is an adequate response.
And thank you for responding on such a short notice.
from neil.
but I don't think that emptying deps.edn is an adequate response
Fully agreed :) This should be fixed.
from neil.
Should be fixed with neil from master now. @akond Can you test this?
from neil.
Yes, now it keeps the file untouched.
But I get no warnings either.
from neil.
Very well, I'll release a new version
from neil.
I assume this is fixed. Please leave a message if it's not.
from neil.
Related Issues (20)
- Error on dep update HOT 1
- Unable to install `com.cnuernber/ham-fisted` with Neil 0.1.59 HOT 2
- `neil dep upgrade` should update unstable versions HOT 2
- Error when running `neil --version` on versions `>=0.1.58` HOT 1
- Suggestion: `neil dep local <lib> <path>` HOT 2
- neil dep upgrade drops dep :exclusions HOT 2
- Neil completely crashes on fresh install HOT 24
- `neil dep add` exits with code 0 on both failure and success HOT 1
- Neil new behaviour different for windows HOT 4
- NPE on `neil dep upgrade ` HOT 5
- suggestion: support `neil add nrepl -with-cider` HOT 3
- Documentation: add git as a requirement HOT 1
- Feature request: a flag that does what `dep search` already does, but works for multiple artifacts and outputs a string suitable for `-Sdeps` HOT 3
- Neil does not use the latest version of slipset/deps-deploy in the `neil add build` command
- suggestion: use DEPS_CLJ_TOOLS_DIR to detect DEPS_CLJ_TOOLS_VERSION HOT 2
- Newlines should be added when adding dependencies HOT 2
- Suggestion: Add human-readable output to `neil dep add` HOT 1
- `neil add kaocha` adds `:kaocha` alias with irregular indent HOT 5
- `neil add` could provide usage help rather than crash HOT 2
- After merging #216, `neil add` produces super long lines for certain aliases HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neil.