GithubHelp home page GithubHelp logo

Comments (9)

borkdude avatar borkdude commented on June 19, 2024 1

One thing to keep in mind is that installers mentioned in the README should also be migrated to the new location.

from neil.

borkdude avatar borkdude commented on June 19, 2024 1

That's an interesting approach! I'd be open to that. I think what should also happen is a check that checks if the generated script still runs before we release.

from neil.

borkdude avatar borkdude commented on June 19, 2024 1

Yes, exactly. It doesn't matter that much. We could move the whole prelude to the neil script so we have only one add-deps call instead of two then.

from neil.

borkdude avatar borkdude commented on June 19, 2024 1

Hm, o no wait, we could get rid of the prelude thing I think, since the deps would be in deps.edn already in the project.

from neil.

borkdude avatar borkdude commented on June 19, 2024

Hmm, I think all packages rely on the script being in the root so maybe it's not a good idea to change this...

from neil.

rads avatar rads commented on June 19, 2024

@borkdude:

Hmm, I think all packages rely on the script being in the root so maybe it's not a good idea to change this...

One option would be to have a GitHub Action on main that would run bb gen-script && git add -f neil on a separate branch, such as release.

This means we could commit to main without the script, but we would have to create tags off of the release branch. I don't think this would require any changes to the packages since they would still use the same tag-based URL.

What do you think about this?

from neil.

rads avatar rads commented on June 19, 2024

Cool, I can start looking into this.

from neil.

borkdude avatar borkdude commented on June 19, 2024

@rads I might have a slightly better idea. The neil script can simply be (babashka.deps/add-deps {:deps {org.babashka/neil {:git/url "..." :git/tag "..." :git/sha "..."}}) and then we can periodically update it.

from neil.

rads avatar rads commented on June 19, 2024

@borkdude: I was originally thinking this might be a drawback because the neil script would incur additional startup time after the brew install. However, now I realize that we are already calling babashka.deps/add-deps in prelude so we are fetching network dependencies on the first run anyways. With that in mind, I think using a simple shim like you're suggesting is a good solution.

from neil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.