Alias option ignored in neil dep add library --alias alias about neil

[kees-]

Thanks for the opportunity to try! I'll either open a pr or comment back!

[borkdude]

Good catch! Do you want us to fix this or would you like to work on a PR yourself?

[rads]

@borkdude: Looks like we can close this issue now that #92 and #104 are merged.

[borkdude]

Somehow this still doesn't work for me.

When I run: neil dep add cheshire/cheshire --alias dude cheshire gets added as a top level dependency.

[borkdude]

@bsless was running into this issue this morning

[kees-]

Hey there, oy, I haven't been lucky taking a stab at what should have been a one-shot fix! Sorry to have prolonged this issue!

Where were you guys running it from? I see that babashka/homebrew-brew doesn't have formulae files for the two most recent tags. So, the version I have installed from brew is 0.1.43 instead of 0.1.45 which I see was released a week before we addressed this issue.

I just tried running from the tag hosted on github and the alias flag worked for me. Or were you having issues with running the current code i.e from the repo?

[kees-]

Just cross-referenced this as well with the new bbin (cool!):

brew uninstall neil # v0.1.43 from homebrew
brew install babashka/brew/bbin
echo -e '\npath+=(/Users/kees/.babashka/bbin/bin)' >> .zshrc && exec zsh
bbin install io.github.babashka/neil
neil --version # => neil 0.1.45

clj -Tnew lib :name test/test && cd test
neil dep add cheshire/cheshire --alias json
cat deps.edn

=>

{:paths ["src" "resources"]
 :deps {org.clojure/clojure {:mvn/version "1.11.1"}}
 :aliases
 {:test
  {:extra-paths ["test"]
   :extra-deps {org.clojure/test.check {:mvn/version "1.1.1"}
                io.github.cognitect-labs/test-runner
                {:git/tag "v0.5.1" :git/sha "dfb30dd"}}}
  :build {:deps {io.github.seancorfield/build-clj
                 {:git/tag "v0.8.2" :git/sha "0ffdb4c"}}
          :ns-default build}
  :json {:extra-deps {cheshire/cheshire {:mvn/version "5.11.0"}}}}}

And it does seem to work fine.

Hadn't known this but a duplicate command installed via brew appears to override what's set in the path, is it possible that's what's going on?

[borkdude]

Aaaah, the brew package was behind. My bad.

[kees-]

Np, your projects have grown to quite an ecosystem! I'm sure there are lots of moving parts. Thanks to you and your collaborators for all the great work