Polyfill missing in output due to bad path handling about broccoli-babel-transpiler

[Turbo87]

that is definitely a bug, thanks for reporting! do you have time to open a PR that fixes the issue?

[Turbo87]

I think the right way to do this would be roughly like this:

var babelCorePath = path.dirname(require.resolve('@babel/core/package.json'));

in that case we shouldn't need the regex anymore at all

[Elberet]

Can do, but I'm not certain on the details. From what I can see, things changed quite a bit.
In the Babel packages I'm using - all from the v7 release - the polyfill is found in ./node_modules/@babel/polyfill/browser.js; is that the right file to include? Should it be renamed?

[Turbo87]

to be honest, I don't know. I guess it would make sense to resolve to @babel/polyfill instead then. but in that case, we will need an explicit dependency on it.

[Elberet]

After spending some time with the code and its tests, I'm wondering what the desired outcome of adding the browserPolyfill flag should actually be:

• just add the polyfill to the output tree?
• place it somewhere where Babel can resolve it while transpiling source scripts?
• all of the above?

Is the option even required for the current version of Babel? It's now all designed around separate packagers that eventually pull the polyfill into a bundle, and Babel will happily transpile scripts that require it even without the browser polyfill script visible at transpile-time.

[Turbo87]

to be honest, I don't know the answers to that either. I would suggest to start digging in https://github.com/babel/ember-cli-babel and see if/how that option is used.